Skip to content

fix(add-funds): mark reverted on-chain transfers as FAILED #2056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MusabShakeel576 merged 1 commit into from
May 7, 2026
Merged

fix(add-funds): mark reverted on-chain transfers as FAILED #2056

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion hooks/useTransferToWallet.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,21 @@ const useTransferToWallet = (
waitForTransactionReceipt(publicClient(srcChainId), {
hash: txHash as `0x${string}`,
})
.then(() => {
.then(receipt => {
// viem resolves with the receipt regardless of execution outcome.
// A reverted on-chain transaction is `status: 'reverted'` — treat
// that as FAILED, not SUCCESS.
if (receipt.status !== 'success') {
updateActivity(capturedTrackingId!, {
status: TransactionStatus.FAILED,
metadata: {
error: 'Transaction reverted on-chain',
failedAt: new Date().toISOString(),
},
});
return;
}

updateActivity(capturedTrackingId!, { status: TransactionStatus.SUCCESS });

track(TRACKING_EVENTS.DEPOSIT_COMPLETED, {
Expand Down
Loading