feat: add course type display in grades overview #143
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds visual course type indicators to the grades overview page by creating a new CourseType component that displays color-coded badges based on the last character of the course ID. The implementation uses colors adapted from the Solvro Planer project to maintain visual consistency across the organization's projects.
- Created a new
CourseTypecomponent with color mappings for seven course types (W, L, C, S, P, D, G) - Integrated the component into the grades table to display course type badges next to course names
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/components/ui/course-type.tsx |
New component that extracts the last character from courseId and renders a color-coded badge based on the course type |
src/pages/grades-page.tsx |
Integrated the CourseType component into the grades table to display type badges alongside course names |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@MarvinRucinski I've opened a new pull request, #144, to work on those changes. Once the pull request is ready, I'll request review from you. |
|
@MarvinRucinski I've opened a new pull request, #145, to work on those changes. Once the pull request is ready, I'll request review from you. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Antoni-Czaplicki
left a comment
Antoni-Czaplicki
left a comment
There was a problem hiding this comment.
Hej, jakbyś mógł przenieść to z poza components/ui - tam trzymamy takie bardziej podstawowe komponenty które używamy w całej aplikacji
Mógłbyś wsm użyć komponentu badge który ma w sobie już podstawy
I ogólnie nazwał bym plik i komponent coś w stylu course type badge żeby było jasne o co chodzi
* Initial plan * fix: add explicit length check for courseId validation Co-authored-by: MarvinRucinski <34074234+MarvinRucinski@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: MarvinRucinski <34074234+MarvinRucinski@users.noreply.github.com>
#145) * Initial plan * refactor: add explicit prop types interface and displayName to CourseType Co-authored-by: MarvinRucinski <34074234+MarvinRucinski@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: MarvinRucinski <34074234+MarvinRucinski@users.noreply.github.com>
…TypeBadge, improve colors
Antoni-Czaplicki
force-pushed
the
65-dodanie-oznaczenia-typu-kursu-w-widoku-ocen
branch
from
2a17ce4 to
cc9dd5c
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Antoni-Czaplicki
deleted the
65-dodanie-oznaczenia-typu-kursu-w-widoku-ocen
branch
|
The preview deployment for Web-testownik-preview failed. 🔴 Last updated at: 2026-01-05 18:10:34 CET |
Te oceny z kursów cząstkowych faktycznie w tym api coś nie chodzą do końca.
Na razie to skipnąłem i dodałem na samym froncie oznaczenia typu kursu nie zmieniając nic innego (taki był clue tego taska).
Kolorki wziąłem z planera Solvro.
