feat(arc): add generic toggle button #205
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR introduces a generic toggle button component to replace resource-specific implementations, making it easier to add toggleable fields to different resources. The new ToggleButton component supports configurable states, icons, variants, and toast messages through resource metadata.
Key changes:
- Added type definitions for toggle configuration (
ToggleStateConfig,ToggleFieldConfig,ToggleToastMessages) - Implemented generic
ToggleButtoncomponent with flexible state management - Configured toggle functionality for NotificationTopics and StudentOrganizations resources
- Deprecated the old
ToggleOrganizationStatusButtoncomponent with migration guidance
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/features/resources/types/internal.ts |
Added TypeScript interfaces for toggle configuration (state config, toast messages, field config) |
src/features/resources/types/index.ts |
Exported new toggle-related types for public API |
src/features/resources/node.ts |
Exported toggle types for server-side usage |
src/features/resources/data/resource-metadata.ts |
Added toggle configurations for NotificationTopics and StudentOrganizations with Polish localization |
src/features/abstract-resource-collection/index.ts |
Exported new ToggleButton component |
src/features/abstract-resource-collection/components/toggle-button.tsx |
Implemented generic toggle button with state management, API integration, and toast notifications |
src/features/abstract-resource-collection/components/toggle-status-button.tsx |
Added deprecation notice with migration example |
src/features/abstract-resource-collection/components/arl-item.tsx |
Replaced specific toggle button with generic implementation using metadata configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/features/abstract-resource-collection/components/toggle-status-button.tsx
Outdated
Show resolved
Hide resolved
src/features/abstract-resource-collection/components/toggle-button.tsx
Outdated
Show resolved
Hide resolved
src/features/abstract-resource-collection/components/toggle-button.tsx
Outdated
Show resolved
Hide resolved
kguzek
requested changes
Dec 3, 2025
src/features/abstract-resource-collection/components/arl-item.tsx
Outdated
Show resolved
Hide resolved
src/features/abstract-resource-collection/components/toggle-button.tsx
Outdated
Show resolved
Hide resolved
src/features/abstract-resource-collection/components/toggle-status-button.tsx
Show resolved
Hide resolved
diffiii
force-pushed
the
feat/abstract-toggle-status-button
branch
from
9afb24e to
e3d79c7
Compare
kguzek
requested changes
Dec 8, 2025
src/features/abstract-resource-collection/components/toggle-status-button.tsx
Outdated
Show resolved
Hide resolved
src/features/abstract-resource-collection/components/toggle-status-button.tsx
Outdated
Show resolved
Hide resolved
src/features/abstract-resource-collection/components/toggle-status-button.tsx
Outdated
Show resolved
Hide resolved
src/features/abstract-resource-collection/components/toggle-status-button.tsx
Outdated
Show resolved
Hide resolved
diffiii
force-pushed
the
feat/abstract-toggle-status-button
branch
4 times, most recently
from
09bfd8c to
f0f114b
Compare
Member
Author
|
Z tego co zauważyłem testy nie przechodzą przez #213 |
diffiii
commented
Dec 9, 2025
Comment on lines
54
to
60
| const fieldValue = getFieldValue( | ||
| body, | ||
| config.field as unknown as ResourceSchemaKey< | ||
| T, | ||
| z.ZodString | z.ZodNumber | ||
| >, | ||
| ) as unknown; |
Member
Author
There was a problem hiding this comment.
Nie mam pomysłu jak to inaczej rozwiązać bez błędu typów
Member
There was a problem hiding this comment.
niech pole "field" będzie w deklaracji configa otypowane jako ResourceSchemaKey<R, z.ZodString | z.ZodNumber>
Member
213 się tyczy kalendarza który jeszcze nie jest zmergowany, więc twoje błędy mogą co najwyżej być podobne a zarazem naprawialne |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
kguzek
force-pushed
the
feat/abstract-toggle-status-button
branch
from
f0f114b to
30753c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #197