fix(multi-select): prevent double-filtering in search #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR fixes a double-filtering bug in the multi-select component's search functionality. The component implements custom filtering logic through filteredOptions that filters based on searchValue, but the Command component was also applying its own filtering on top of the already-filtered results.
- Added
shouldFilter={false}prop to the Command component to disable its built-in filtering
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
diffiii
force-pushed
the
fix/multi-select-search
branch
from
9eb1ab4 to
ae556dc
Compare
diffiii
force-pushed
the
fix/multi-select-search
branch
from
ae556dc to
86c10b2
Compare
kguzek
reviewed
Dec 12, 2025
Member
kguzek
left a comment
kguzek
left a comment
There was a problem hiding this comment.
tu się tyle zadziało że nawet nie wiem od czego zacząć. jesteś w stanie uzasadnić tą ogromną ilość zmian w stosunku do poprzedniego rozwiązania?
kguzek
force-pushed
the
fix/multi-select-search
branch
from
86c10b2 to
34a3027
Compare
diffiii
force-pushed
the
fix/multi-select-search
branch
from
34a3027 to
068b257
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sersavan/shadcn-multi-select-component#73
Resolves #129