You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Make rich‑text editor field types valid and fully wired for quill, tinymce, and easymde (and ensure existing markdown renders with the rich‑text container).
Author: Rob Walton (@bobbwal) Fixes: #569 - Missing rich-text field types in FieldType union
Summary
This PR adds support for quill, tinymce, and easymde field types to make rich-text editor fields valid in collection schemas. It addresses a TypeScript type-checking error when using these editor types.
Changes Analysis
1. packages/core/src/types/collection-config.ts
✅ Good: Adds the three missing field types to the FieldType union:
The docs also suggest we can also use type: 'easymde' and type: 'markdown' for EasyMDE.
These don't seem to work for me, I just get a text field? I feel like these did work at some point so it could well be something to do with my local setup. https://sonicjs.com/plugins#editor-plugins
type: 'mdxeditor' and type: 'quill' work for me.
I also have 2 EasyMDE plugins: EasyMDE Markdown Editor and EasyMDE Editor. I'm guessing one is the old MDXEditor?
Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make rich‑text editor field types valid and fully wired for quill, tinymce, and easymde (and ensure existing markdown renders with the rich‑text container).
Fixes #569
Changes
quill,tinymce, andeasymdetoFieldType.tinymce,easymde, andmarkdownwith the rich‑text container and plugin fallbacks.admin-collections.ts.Testing
npm run type-checknpm testnpm run e2eUnit Tests
E2E Tests
Checklist
———
Generated with Claude Code in Conductor