ci: gate construct-cli with cargo fmt, clippy, test, and an MSRV check

[UnbreakableMJ]

Why

construct-cli/ is the only real build surface in this repo — everything else is markdown — and it was entirely ungated. The existing lint job runs reuse lint, config validation, and the description cap; it never invokes cargo.

That is how a clippy break (items_after_test_module in src/sources/skillmd.rs) sat unnoticed on main until #26 tripped over it and had to fix it as a drive-by.

Jobs added

Job	Runs	Toolchain
cargo	fmt --check, clippy --all-targets -- -D warnings, test	stable
msrv	cargo check --all-features	1.82 (the declared rust-version)

Both use Swatinem/rust-cache.

Decisions worth reviewing

Stable for the gate, MSRV separately. Pinning the main gate to 1.82 would freeze clippy lints and rustfmt output at whatever that release emitted. Keeping MSRV as its own job also means an MSRV bump is a visible, deliberate change rather than something that rides along with a dependency update. It runs check, not test — dev-dependencies are not bound by the MSRV the crate advertises to consumers.

Not path-filtered. A path-filtered job reports nothing at all when skipped, which makes it unusable as a required status check. With the cache, a markdown-only PR is cheap enough that always running is the better trade.

cargo audit deliberately excluded. A newly published advisory would redden main for a reason unrelated to the change under review. It stays a local step before adding a dependency (Standard §3.3). If it belongs in CI later, a scheduled job is the right shape — not a PR gate.

Docs

construct-cli/AGENTS.md now records what is gated and what is not, including why cargo audit is absent and why a clippy finding should be fixed rather than pinned around. Its peer CLAUDE.md got the identical edit but is gitignored, so it is not in this diff — the two remain identical apart from their self-reference line, as that file pair requires.

Verification

The workflow YAML parses under .github/validate-configs.py (309 config files, 0 failed). Locally: cargo fmt --check, cargo clippy --all-targets -- -D warnings, and cargo test (40 passed) are all clean on this branch.

The msrv job is unverified locally — I had no 1.82 toolchain to hand, so this PR is the first real test of it. If it fails, the fix is either a rust-version bump in Cargo.toml to match what the code actually needs, or dropping the job; I'll resolve it here before merge rather than land a red gate.

🤖 Generated with Claude Code

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.