Fix/ci build system #17
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey :)
I've noticed the CI failing, so I've prompted gemini how to fix it. This is what we propose:
PR Description
Overview
Resolves CI failures on master by separating the core library build from tool-specific dependencies. Also updates the build system and improves Nix support.
This should make the CI workflow less dependent, as simapi now builds without simd initially.
Detailed Changes
1. Build System (CMake)
Root CMakeLists.txt
cmake_minimum_requiredto 3.15.BUILD_SIMDoption (default ON) to allow building without simd deps.PUBLIC.simd/CMakeLists.txt
2. CI & Infrastructure
GitHub Actions
-DBUILD_SIMD=OFF.Nix (flake.nix)
self.submodules = trueto avoid failures due to missing codegen/cfile.argtableattribute.nativeBuildInputsandbuildInputs.Verification Results
cmake -B build -DBUILD_SIMD=OFFbuilds successfully.nix build .#simapiandnix build .#simdboth succeed.Neither argtable3 nor argtable2 foundfailure observed previously.