-
Notifications
You must be signed in to change notification settings - Fork 278
chore(cmd/ui): fetch dagrejs via HTTPS #2097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Build systems which don't use the yarn cache can't fetch git dependencies via ssh if no valid credentials are found, e.g. when the build is run in a sandbox.
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
WalkthroughThe dagrejs dependency in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (1)📚 Learning: 2025-08-11T18:25:23.685ZApplied to files:
🔇 Additional comments (1)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
I have read the CLA Document and I hereby sign the CLA |
SuperSandro2000
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a problem specific to nix but any CI like thing that clones repo would not work with this without having credentials. See eg. https://git-scm.com/docs/git-push#_git_urls on how to configure your git client to still use authentication when pushing or use gh credential helper.
|
@42LoCo42 @SuperSandro2000 Had a quick question for one of you! I suspect this comes from my lack of understanding of how the nix build system works, but I'm curious why our yarn cache can't be used? We have a cached version of the dagrejs asset here, so we usually do not need to clone these assets. |
We try to build as much as possible from source to fully trust the build result. The build sandbox has no internet connectivity and we use a special fetcher before who does yarn install and then copies the files into place that normal yarn commands work as expected. Those kinds of custom cache things just don't work for us. Also the cache seems to be 2 years old and I have my doubts that it works as expected in all environments. Frankly, this is the first time I am seeing something like this. Cloning repos with ssh is also a major problem for git submodules where https must also be always used. |
Build systems which don't use the yarn cache can't fetch git dependencies via ssh if no valid credentials are found, e.g. when the build is run in a sandbox.
Description
This PR replaces the SSH URL for dagrejs in
cmd/ui/package.jsonwith an equivalent HTTPS URL,thus allowing build systems to fetch dagrejs without requiring access to SSH credentials.
Motivation and Context
Resolves #2096
This change is required to build BloodHound with build systems that don't use the yarn cache included in this repository and also run builds in a sandbox with no access to SSH credentials.
How Has This Been Tested?
I'm packaging BloodHound for Nix in NixOS/nixpkgs#461387.
There, I currently use a patch roughly equivalent to this PR in order to fix the build issue. With it, the BloodHound package builds successfully.
On a system with Nix installed & Flakes enabled, the package can be built like this:
Types of changes
Checklist:
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.