Skip to content

Conversation

@LuemmelSec
Copy link
Contributor

Some queries added to the pool.

@d3vzer0 d3vzer0 added the enhancement New feature or request label Jun 20, 2025
@d3vzer0 d3vzer0 self-assigned this Jun 20, 2025
@d3vzer0
Copy link
Collaborator

d3vzer0 commented Jun 20, 2025

@LuemmelSec Thanks for submitting extra queries! :) I'll take a look and fix the included tests - the action doesn't include your additions at this moment.

One note in advance: I believe you're missing the '.yml' extension for one of your query files: aa26218

@LuemmelSec
Copy link
Contributor Author

@LuemmelSec Thanks for submitting extra queries! :) I'll take a look and fix the included tests - the action doesn't include your additions at this moment.

One note in advance: I believe you're missing the '.yml' extension for one of your query files: aa26218

Fixed that ;)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LuemmelSec I see you're refering to m.system_tags but "m" is not declared yet. This should probably be n.system_tags? :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sharp eye. Probably fd up during copy pasta :)

@JonasBK
Copy link
Collaborator

JonasBK commented Sep 2, 2025

Hey @LuemmelSec!

Thanks a lot for the contribution :)
I added a couple of comments regarding usages of our cypher shortcuts. Let me know if you have any questions!

@LuemmelSec
Copy link
Contributor Author

Hey @LuemmelSec!

Thanks a lot for the contribution :) I added a couple of comments regarding usages of our cypher shortcuts. Let me know if you have any questions!

Hey bud, nice to see you alive ^^
Made the changes you suggested.

Copy link
Collaborator

@martinsohn martinsohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I especially like Accounts related to AAD Entra Connect. Thank you for the contribution (and sorry for the delay!).

@d3vzer0 d3vzer0 merged commit a733a23 into SpecterOps:main Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants