BED-6848 chore: version bump to v2.8.1 #189
Conversation
WalkthroughBumps assembly Version and FileVersion from 2.8.0 to 2.8.1 and updates NuGet references for Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
definitelynotagoblin
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
Sharphound.csproj(2 hunks)
🔇 Additional comments (1)
Sharphound.csproj (1)
9-10: Verify the version bump rationale and document changes.The assembly version is being bumped from 2.8.0 directly to 2.8.2 (skipping 2.8.1). Ensure this is intentional and aligns with your versioning strategy.
Additionally, the PR description is empty. Consider populating it with:
- A changelog summary of what changed between 2.8.0 and 2.8.2
- Any breaking changes or migration notes
- Release notes or highlights
| <PackageReference Include="SharpHoundCommon" Version="4.5.1" /> | ||
| <PackageReference Include="SharpHoundRPC" Version="4.5.1" /> |
There was a problem hiding this comment.
🧩 Analysis chain
Script executed:
#!/bin/bash
# Description: Verify NuGet package versions are available and check for known issues.
# Check SharpHoundCommon 4.5.1 availability
echo "Checking SharpHoundCommon 4.5.1..."
curl -s "https://api.nuget.org/v3-flatcontainer/sharphoundcommon/4.5.1/sharphoundcommon.nuspec" | head -30
echo -e "\n\nChecking SharpHoundRPC 4.5.1..."
# Check SharpHoundRPC 4.5.1 availability (corrected typo from original)
curl -s "https://api.nuget.org/v3-flatcontainer/sharphouindrpc/4.5.1/sharphouindrpc.nuspec" | head -30
echo -e "\n\nChecking package metadata for both packages..."
# Try alternative endpoint to get package info
curl -s "https://api.nuget.org/v3/registration5-gz/sharphoundcommon/index.json" | python3 -m json.tool 2>/dev/null | grep -A 5 "4.5.1" | head -20Repository: SpecterOps/SharpHound
<shell_result>
Repository: SpecterOps/SharpHound
Script execution failed with error: Request timed out after 120000ms (requestId=ddc2a94d-3d96-47db-9436-c426fe1574fb)
</shell_result>
NuGet SharpHoundRPC 4.5.1 release notes changelog
<web_search_result>
I can't find a NuGet package or release notes for "SharpHoundRPC 4.5.1". I searched NuGet and GitHub; related SharpHound repositories and NuGet packages (e.g., SharpHoundCommon) exist but no SharpHoundRPC 4.5.1 release/changelog was found. (github.com)
Do you have a package URL or repository link I should check, or should I broaden the search (other registries, forks, or mirrors)?
Citations:
- 1: https://github.com/SpecterOps/SharpHound?utm_source=openai
</web_search_result>
Script executed:
#!/bin/bash
# Search codebase for all PackageReference entries to understand dependencies
echo "=== Searching for PackageReference entries in csproj files ==="
find . -name "*.csproj" -type f -exec grep -l "PackageReference" {} \;
echo -e "\n=== Displaying PackageReference content from Sharphound.csproj ==="
find . -name "Sharphound.csproj" -type f -exec cat {} \;Repository: SpecterOps/SharpHound
<shell_result>
Repository: SpecterOps/SharpHound
Exit code: 0
stdout:
=== Searching for PackageReference entries in csproj files ===
./Sharphound.csproj
=== Displaying PackageReference content from Sharphound.csproj ===
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net472</TargetFramework>
<LangVersion>latest</LangVersion>
<DebugType>full</DebugType>
<ApplicationIcon>favicon.ico</ApplicationIcon>
<Version>2.8.2</Version>
<FileVersion>2.8.2</FileVersion>
<Company>SpecterOps</Company>
<Product>SharpHound</Product>
<AssemblyName>SharpHound</AssemblyName>
<AllowUnsafeBlocks>True</AllowUnsafeBlocks>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="CommandLineParser" Version="2.8.0" />
<PackageReference Include="Costura.Fody" Version="5.7.0">
<PrivateAssets>all</PrivateAssets>
</PackageReference>
<PackageReference Include="Fody" Version="6.6.0">
<PrivateAssets>all</PrivateAssets>
</PackageReference>
<PackageReference Include="Microsoft.Bcl.AsyncInterfaces" Version="8.0.0" />
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="8.0.0" />
<PackageReference Include="Newtonsoft.Json" Version="13.0.1" />
<PackageReference Include="SharpHoundCommon" Version="4.5.1" />
<PackageReference Include="SharpHoundRPC" Version="4.5.1" />
<PackageReference Include="SharpZipLib" Version="1.3.3" />
<PackageReference Include="System.Runtime.CompilerServices.Unsafe" Version="6.0.0" />
<PackageReference Include="System.Threading.Channels" Version="8.0.0" />
<PackageReference Include="System.ValueTuple" Version="4.5.0" />
</ItemGroup>
<ItemGroup>
<!-- <Reference Include="SharpHoundCommon">-->
<!-- <HintPath>..\SharpHoundCommon\src\CommonLib\bin\Debug\net472\SharpHoundCommonLib.dll</HintPath>-->
<!-- </Reference>-->
<Reference Include="System.DirectoryServices" />
<Reference Include="System.DirectoryServices.Protocols" />
<Reference Include="System.IO.Compression" />
</ItemGroup>
<Target Name="PS1" AfterTargets="Build" Condition="$([MSBuild]::IsOSPlatform('Windows'))">
<Message Text="Test" />
<Exec Command="powershell -ep bypass -c ". '$(ProjectDir)src\Powershell\Out-CompressedDLL.ps1';Out-CompressedDll -FilePath '$(TargetPath)' -TemplatePath '$(ProjectDir)src\\Powershell\Template.ps1' | Out-File -Encoding ASCII '$(TargetDir)$(TargetName).ps1'"" />
</Target>
</Project>
</shell_result>
SharpHoundCommon NuGet package versions available
<web_search_result>
Available SharpHoundCommon NuGet versions (as listed on nuget.org): 3.0.8, 3.0.4, 3.0.3, 3.0.2, 3.0.1, 3.0.0-rc11, 3.0.0-rc10, 3.0.0-rc9, 3.0.0-rc8, 3.0.0-rc7, 3.0.0-rc6, 3.0.0-rc4, 3.0.0-rc3, 3.0.0-rc2, 3.0.0-rc1, 2.1.2, 2.1.1, 2.1.0, 2.0.15, 2.0.14, 2.0.13, 2.0.12, 2.0.11, 2.0.10, 2.0.9, 2.0.8, 2.0.7, 2.0.6, 2.0.4, 2.0.3, 2.0.2, 2.0.1, 2.0.0, 1.1.3, 1.1.2, 1.1.1, 1.1.0, 1.0.16, 1.0.15, 1.0.14, 1.0.13, 1.0.12, 1.0.11, 1.0.10, 1.0.9, 1.0.8, 1.0.7, 1.0.6, 1.0.5, 1.0.4, 1.0.3, 1.0.2, 1.0.1, 1.0.0. [1]
Source: nuget.org package page for SharpHoundCommon. [1]
</web_search_result>
SharpHoundRPC NuGet package exists
<web_search_result>
I couldn't find a NuGet package named "SharpHoundRPC" on nuget.org. The related SharpHoundCommon package exists on NuGet (example page). [1][2]
Sources:
- SharpHoundCommon package on NuGet. [1]
- NuGet.org search/help (how to find packages). [2]
If you want, I can run a more specific search (GitHub, other feeds) or check for similarly named packages.
</web_search_result>
Script executed:
#!/bin/bash
# Check for NuGet configuration files
echo "=== Searching for NuGet configuration ==="
find . -name "NuGet.config" -o -name "nuget.config" | head -20
echo -e "\n=== Checking for any documentation about packages ==="
find . -name "README*" -o -name "*.md" | head -10
echo -e "\n=== Searching codebase for package source references ==="
grep -r "nuget\|package" . --include="*.config" --include="*.xml" 2>/dev/null | head -20Repository: SpecterOps/SharpHound
<shell_result>
Repository: SpecterOps/SharpHound
Exit code: 0
stdout:
=== Searching for NuGet configuration ===
./nuget.config
=== Checking for any documentation about packages ===
./.github/pull_request_template.md
./README.md
=== Searching codebase for package source references ===
./nuget.config: <packageSources>
./nuget.config: <add key="nuget.org" value="https://api.nuget.org/v3/index.json" protocolVersion="3" />
./nuget.config: </packageSources>
</shell_result>
SharpHoundCommon 4.5.1 NuGet package SpecterOps
<web_search_result>
Short answer: There is no SharpHoundCommon NuGet package version 4.5.1. The SharpHoundCommon package on nuget.org is published by the BloodHound/SpecterOps project and available versions include 1.x → 3.x (the NuGet listing shows 3.0.8 as a recent publish). [1][2][3]
Sources:
- SharpHoundCommon (NuGet package page, version list including 3.0.8 and 1.1.1). [1][2]
- SpecterOps SharpHound GitHub / SpecterOps information about SharpHound and “BloodHound Common.” [3][4]
If you want, I can: fetch the exact latest SharpHoundCommon version on nuget.org right now and give the dotnet/NuGet install command. Which would you prefer?
</web_search_result>
SharpHoundRPC NuGet SpecterOps package
<web_search_result>
Short answer: There is no official "SharpHoundRPC" NuGet package from SpecterOps. SpecterOps publishes SharpHound on GitHub (the collector/source) and related NuGet packages like SharpHoundCommon exist on nuget.org, but a package named SharpHoundRPC does not appear in the NuGet registry. [1][2]
Sources:
- SpecterOps / SharpHound (GitHub). [1]
- SharpHoundCommon package on NuGet.org. [2]
</web_search_result>
NuGet packages do not exist; package references are invalid and will cause build failure.
The referenced versions are unavailable:
- SharpHoundCommon 4.5.1 does not exist on nuget.org (latest available: 3.0.8)
- SharpHoundRPC 4.5.1 does not exist as a NuGet package at all
The nuget.config only uses the official nuget.org source, so no private feeds can resolve these. The PR will fail during package restore with 404 errors.
Correct the package names/versions before merging, or verify these are meant to reference internal packages from a private feed that needs to be configured.
🤖 Prompt for AI Agents
In Sharphound.csproj around lines 28-29 the project references non-existent
NuGet packages SharpHoundCommon 4.5.1 and SharpHoundRPC 4.5.1 which will cause
restore failures; update the PackageReference entries to valid package
names/versions (for example set SharpHoundCommon to the latest published 3.0.8)
or remove/replace SharpHoundRPC with the correct package if it has a different
name, or alternatively add the private feed that hosts these internal packages
to nuget.config; ensure the project restores successfully after making one of
these changes.
juggernot325
changed the title
Description
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Summary by CodeRabbit
Release Notes
✏️ Tip: You can customize this high-level summary in your review settings.