Skip to content

Conversation

@jeff-matthews
Copy link
Contributor

@jeff-matthews jeff-matthews commented Dec 23, 2025

Purpose

This pull request (PR) removes germany from the list of Azure regions in the AzureHound configuration docs.

See BED-4601 for details.

Summary by CodeRabbit

  • Documentation
    • Updated AzureHound Enterprise CLI version displayed from v2.0.5 to v2.8.2.
    • Removed the "germany" option from the Azure region selection, narrowing available regions.

✏️ Tip: You can customize this high-level summary in your review settings.

@jeff-matthews jeff-matthews self-assigned this Dec 23, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 23, 2025

Walkthrough

Updated AzureHound configuration docs: CLI tool version text changed from v2.0.5 to v2.8.2 and the "germany" option was removed from the Azure region selection prompt.

Changes

Cohort / File(s) Summary
Documentation update
docs/install-data-collector/install-azurehound/create-configuration.mdx
Updated displayed AzureHound CLI version from v2.0.5 to v2.8.2; removed "germany" from the Azure region choices in the prompt.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • StephenHinck

Poem

🐰 A tiny hop, a tidy tweak,
Version leaps as docs speak,
Germany waves a gentle bye,
Regions trimmed beneath the sky,
I nibble carrots and then I squeak. 🥕

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title 'docs: remove deprecated Azure region' directly and accurately summarizes the main change: removing the deprecated 'germany' Azure region from documentation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch azurehound-regions

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cc8f5c8 and 4935a91.

📒 Files selected for processing (1)
  • docs/install-data-collector/install-azurehound/create-configuration.mdx
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: StephenHinck
Repo: SpecterOps/bloodhound-docs PR: 42
File: docs/install-data-collector/install-azurehound/system-requirements.mdx:70-73
Timestamp: 2025-08-08T15:57:55.743Z
Learning: For AzureHound docs (docs/install-data-collector/install-azurehound/system-requirements.mdx), prefer explicitly stating:
- Directory Reader must be permanently active (not PIM-eligible only).
- Microsoft Graph application permissions (Directory.Read.All, RoleManagement.Read.All) require admin consent.
- Azure Reader role phrasing: “on all Azure subscriptions, ideally assigned at the tenant root group (root management group) scope.”
📚 Learning: 2025-08-08T15:57:55.743Z
Learnt from: StephenHinck
Repo: SpecterOps/bloodhound-docs PR: 42
File: docs/install-data-collector/install-azurehound/system-requirements.mdx:70-73
Timestamp: 2025-08-08T15:57:55.743Z
Learning: For AzureHound docs (docs/install-data-collector/install-azurehound/system-requirements.mdx), prefer explicitly stating:
- Directory Reader must be permanently active (not PIM-eligible only).
- Microsoft Graph application permissions (Directory.Read.All, RoleManagement.Read.All) require admin consent.
- Azure Reader role phrasing: “on all Azure subscriptions, ideally assigned at the tenant root group (root management group) scope.”

Applied to files:

  • docs/install-data-collector/install-azurehound/create-configuration.mdx
🔇 Additional comments (2)
docs/install-data-collector/install-azurehound/create-configuration.mdx (2)

60-60: No actionable issues identified. The version update from v2.0.5 to v2.8.2 is intentional and complete. v2.8.2 is confirmed as the current AzureHound version (per Dec 2, 2025 release notes), and the old version references that remain are historical release notes where they appropriately belong. The documentation for the active install procedure has been correctly updated.


74-79: Germany region removal is complete and appropriate.

The removal aligns with Microsoft Azure's official transition away from the "Microsoft Cloud Germany" (T‑Systems trustee model) to new German regions. No remaining references to the "germany" region were found in the documentation. The change is correct.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
docs/install-data-collector/install-azurehound/create-configuration.mdx (1)

60-60: Update the example path to match the current version.

The example path references azurehound-v2.0.5 while the CLI output on line 70 displays v2.8.2. This version mismatch may confuse users following the documentation.

🔎 Proposed fix
-      C:\Users\Administrator.ROOT\Downloads\azurehound-v2.0.5\azurehound-windows-amd64>azurehound.exe configure
+      C:\Users\Administrator.ROOT\Downloads\azurehound-v2.8.2\azurehound-windows-amd64>azurehound.exe configure

Alternatively, consider making the path version-agnostic:

-      C:\Users\Administrator.ROOT\Downloads\azurehound-v2.0.5\azurehound-windows-amd64>azurehound.exe configure
+      C:\Users\Administrator.ROOT\Downloads\azurehound\azurehound-windows-amd64>azurehound.exe configure
📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 56de383 and cc8f5c8.

📒 Files selected for processing (1)
  • docs/install-data-collector/install-azurehound/create-configuration.mdx
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-08-08T15:57:55.743Z
Learnt from: StephenHinck
Repo: SpecterOps/bloodhound-docs PR: 42
File: docs/install-data-collector/install-azurehound/system-requirements.mdx:70-73
Timestamp: 2025-08-08T15:57:55.743Z
Learning: For AzureHound docs (docs/install-data-collector/install-azurehound/system-requirements.mdx), prefer explicitly stating:
- Directory Reader must be permanently active (not PIM-eligible only).
- Microsoft Graph application permissions (Directory.Read.All, RoleManagement.Read.All) require admin consent.
- Azure Reader role phrasing: “on all Azure subscriptions, ideally assigned at the tenant root group (root management group) scope.”

Applied to files:

  • docs/install-data-collector/install-azurehound/create-configuration.mdx
🔇 Additional comments (1)
docs/install-data-collector/install-azurehound/create-configuration.mdx (1)

70-79: The removal of the "germany" region is appropriate. Azure's original "Microsoft Cloud Germany" (the Deutschland data-trustee model) was deprecated in August 2018, and Microsoft no longer accepts new customers or adds services to it. No other references to the "germany" region exist in the documentation.

@jeff-matthews jeff-matthews merged commit a86a40e into main Dec 23, 2025
3 checks passed
@jeff-matthews jeff-matthews deleted the azurehound-regions branch December 23, 2025 18:17
@github-actions github-actions bot locked and limited conversation to collaborators Dec 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants