-
Notifications
You must be signed in to change notification settings - Fork 5
docs: remove deprecated Azure region #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughUpdated AzureHound configuration docs: CLI tool version text changed from v2.0.5 to v2.8.2 and the "germany" option was removed from the Azure region selection prompt. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (2)📓 Common learnings📚 Learning: 2025-08-08T15:57:55.743ZApplied to files:
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
docs/install-data-collector/install-azurehound/create-configuration.mdx (1)
60-60: Update the example path to match the current version.The example path references
azurehound-v2.0.5while the CLI output on line 70 displaysv2.8.2. This version mismatch may confuse users following the documentation.🔎 Proposed fix
- C:\Users\Administrator.ROOT\Downloads\azurehound-v2.0.5\azurehound-windows-amd64>azurehound.exe configure + C:\Users\Administrator.ROOT\Downloads\azurehound-v2.8.2\azurehound-windows-amd64>azurehound.exe configureAlternatively, consider making the path version-agnostic:
- C:\Users\Administrator.ROOT\Downloads\azurehound-v2.0.5\azurehound-windows-amd64>azurehound.exe configure + C:\Users\Administrator.ROOT\Downloads\azurehound\azurehound-windows-amd64>azurehound.exe configure
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/install-data-collector/install-azurehound/create-configuration.mdx
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-08-08T15:57:55.743Z
Learnt from: StephenHinck
Repo: SpecterOps/bloodhound-docs PR: 42
File: docs/install-data-collector/install-azurehound/system-requirements.mdx:70-73
Timestamp: 2025-08-08T15:57:55.743Z
Learning: For AzureHound docs (docs/install-data-collector/install-azurehound/system-requirements.mdx), prefer explicitly stating:
- Directory Reader must be permanently active (not PIM-eligible only).
- Microsoft Graph application permissions (Directory.Read.All, RoleManagement.Read.All) require admin consent.
- Azure Reader role phrasing: “on all Azure subscriptions, ideally assigned at the tenant root group (root management group) scope.”
Applied to files:
docs/install-data-collector/install-azurehound/create-configuration.mdx
🔇 Additional comments (1)
docs/install-data-collector/install-azurehound/create-configuration.mdx (1)
70-79: The removal of the "germany" region is appropriate. Azure's original "Microsoft Cloud Germany" (the Deutschland data-trustee model) was deprecated in August 2018, and Microsoft no longer accepts new customers or adds services to it. No other references to the "germany" region exist in the documentation.
Purpose
This pull request (PR) removes
germanyfrom the list of Azure regions in the AzureHound configuration docs.See BED-4601 for details.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.