Open
Conversation
danielbosnich
changed the title
danielbosnich
commented
Feb 28, 2026
| "net/http" | ||
| "net/url" | ||
| "os" | ||
| "path/filepath" |
Author
There was a problem hiding this comment.
@cordellfreeman, looks like you didn't generate code in #9. That's something we should do, right? Just curious if we're trying to keep these generated files up-to-date.
Collaborator
There was a problem hiding this comment.
I probably just forgot. It appears we've done it in all the other PRs so it's good to keep doing
cordellfreeman
approved these changes
Mar 2, 2026
Collaborator
cordellfreeman
left a comment
cordellfreeman
left a comment
There was a problem hiding this comment.
I'm not sure what 'dataType` function is or what it does. If it's dead, I think removing it is fine. If somebody does need it, then can add it back easily
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the logic for handling optional string query parameters with a default value. Previously, we would initialize a string value with the default value but then pass it in to a function that was expecting a
*stringtype.One thing I'm not totally sure about is if we need the
dataTypefunction call. That also doesn't work as currently written (since it's not used for the default value) but after some experimentation I'm thinking that this might be dead code. It looks like we don't support default values for string enums, so I'm not sure how this would get executed currently.