Adding quotes around micronucleus hex upload#896
Open
victorsowa12 wants to merge 1 commit intoSpenceKonde:v2.0.0-devThis-is-the-head-submit-PRs-against-thisfrom
Open
Conversation
|
👍 Same problem here. See #904. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding quotes around the hex file paths in the micronucleus upload commands. I'm a goof and I have a space in my windows user name, so the upload was failing with a "cannot find
path/to/.hexfile" that was clearly split at that space in my user name. I've fixed it on my local package for v1.5.2, but saw it was still an issue on the v2.0.0 dev branch.