Skip to content

Fix typo in lupin/tdc2 #4284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alejoe91 wants to merge 3 commits into
base: main
Choose a base branch
from
+7 −5
Open

Fix typo in lupin/tdc2 #4284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b5f4fb1
Fix typo in lupin/tdc2
alejoe91 Dec 29, 2025
32933b2
Add astype float32 if external preprocessing dict
alejoe91 Dec 29, 2025
b2547fc
Propagate job_kwargs properly to cache_preprocessing
alejoe91 Dec 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/spikeinterface/sorters/internal/lupin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,8 @@ def _run_from_folder(cls, sorter_output_folder, params, verbose):
if apply_cmr:
recording = common_reference(recording)
else:
recording = apply_preprocessing_pipeline(recording, params["preprocessing_dict"])
recording = apply_preprocessing_pipeline(recording_raw, params["preprocessing_dict"])
recording = recording.astype("float32")

recording = whiten(
recording,
Expand Down
3 changes: 2 additions & 1 deletion src/spikeinterface/sorters/internal/tridesclous2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,8 @@ def _run_from_folder(cls, sorter_output_folder, params, verbose):
if apply_cmr:
recording = common_reference(recording)
else:
recording = apply_preprocessing_pipeline(recording, params["preprocessing_dict"])
recording = apply_preprocessing_pipeline(recording_raw, params["preprocessing_dict"])
recording = recording.astype("float32")

if params["apply_motion_correction"]:
interpolate_motion_kwargs = dict(
Expand Down
6 changes: 3 additions & 3 deletions src/spikeinterface/sortingcomponents/tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,11 +429,11 @@ def cache_preprocessing(

elif mode == "folder":
assert folder is not None, "cache_preprocessing(): folder must be given"
recording = recording.save_to_folder(folder=folder)
recording = recording.save_to_folder(folder=folder, **job_kwargs)
cache_info["folder"] = folder
elif mode == "zarr":
assert folder is not None, "cache_preprocessing(): folder must be given"
recording = recording.save_to_zarr(folder=folder)
recording = recording.save_to_zarr(folder=folder, **job_kwargs)
cache_info["folder"] = folder
elif mode == "no-cache":
recording = recording
Expand All @@ -445,7 +445,7 @@ def cache_preprocessing(
cache_info["mode"] = "memory"
elif folder is not None:
# then try folder
recording = recording.save_to_folder(folder=folder)
recording = recording.save_to_folder(folder=folder, **job_kwargs)
cache_info["mode"] = "folder"
cache_info["folder"] = folder
else:
Expand Down