fix: more consistent borrow progress colors#404
Merged
KevinMehrabi merged 4 commits intomainfrom Feb 22, 2025
Merged
Conversation
Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>
SiddharthV1
approved these changes
Sep 9, 2024
Contributor
|
Although much better, it's still not precise. We can do better. It should be consistent to every increment of change, within <0.0001% margin variability.(of 100.0000%). Seemless to the onlooker. |
Contributor
Author
|
@KevinMehrabi that's how the UI component works, it blends the colors from the edge so a bit of the next color shade seeps into the previous one. |
Contributor
|
It mustn’t do This. That defeats the purpose. On Sep 11, 2024, at 6:35 AM, Soumya Ghosh Dastidar ***@***.***> wrote:
@KevinMehrabi that's how the UI component works, it blends the colors from the edge so a bit of the next color shade seeps into the original one.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>
Contributor
Author
|
Updated it with different component |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #367