BUNNYDNS: Add SVCB and HTTPS support #3937
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hello friend! The merging/separating Tager/Params looks fine by me! As far as tests 17 and 19. You can add functions for HttpsHasNullTarget / ScvbHasNullTarget yourself. I'd recommend putting them in pkg/rejectif/httpsscvb.go (a new file). The testing framework should automatically skip the "Change HTTPS params-empty" step. Look at other rejectif/*.go files for examples. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Requests adds support for the SVCB and HTTPS records to the BUNNY_DNS provider.
Value). Happy to hear any feedback about this.17:HTTPS:Change_HTTPS_params-emptyand19:SVCB:Change_SVCB_params-empty- but this is a requirement from Bunny.net's side. Not sure if there's anything that needs to be added to dnscontrol to handle this scenario. (This would be something forauditrecords.go, but there's no module for SVCB/HTTPS that I can see)