Option for fast load. Default is true#173
Option for fast load. Default is true#173inuex35 wants to merge 3 commits intoStanford-NavLab:mainfrom
Conversation
|
@inuex35 can I get some additional context on your desired change? It looks like in the main branch of georinex, fast already defaults to true? https://github.com/geospace-code/georinex/blob/729b85af584153ac052e81e7652e145c5a5ebb9c/src/georinex/base.py#L29 |
|
Hi this is for rinex ver3, it looks main branch has not supported fast load with version 3 yet. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #173 +/- ##
=======================================
Coverage 99.66% 99.66%
=======================================
Files 27 27
Lines 3883 3883
=======================================
Hits 3870 3870
Misses 13 13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Got it, thanks. We'll wait until those changes get filtered up into georinex main and a new version is released on pypi so we can correctly tag it in our dependency requirements. I saw you were making some changes to the georinex repo yourself too. I was able to get code pulled into main by making a pull request and tagging the main maintainer. It just took a very, very, very long time for them to approve it and merge. Thanks for using glp! |
Fast load is enabled for rinex
40 min -> 40 sec
with georinex develop branch