feat: Local project settings singleton #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stan-osipov
requested changes
Mar 8, 2021
Contributor
stan-osipov
left a comment
stan-osipov
left a comment
There was a problem hiding this comment.
minor changes requested.
| public const string SettingsPath = "Assets/Plugins/StansAssets/Settings"; | ||
|
|
||
| /// <summary> | ||
| /// Package runtime settings location path. |
Contributor
There was a problem hiding this comment.
Suggested change
| /// Package runtime settings location path. | |
| /// Library settings folder path. |
| { | ||
| // Only applicable while in the editor. | ||
| #if UNITY_EDITOR | ||
| var path = Path.Combine(asset.SettingsFilePath); |
Contributor
There was a problem hiding this comment.
Why do we use Path.Combine here?
| StreamReader reader = null; | ||
| try | ||
| { | ||
| reader = new StreamReader(asset.SettingsFilePath); |
Contributor
There was a problem hiding this comment.
And not using Path.Combine here?
stan-osipov
reviewed
Mar 24, 2021
Comment on lines
+15
to
+19
| public LocalProjectSettings(string packageName, string settingsFileName = null) | ||
| { | ||
| PackageName = packageName; | ||
| SettingsFileName = settingsFileName == null ? settingsFileName : GetType().Name; | ||
| } |
Contributor
There was a problem hiding this comment.
Why do we need it and where do we use it?
Plus seems like we should have ILocalProjectSettings & StansAssetsLocalProjectSettings that holds basic path implementations like $"{Application.dataPath}/{PackagesConfig.LibraryPath}/{PackageName}"; ets.
stan-osipov
requested changes
Mar 24, 2021
Contributor
stan-osipov
left a comment
stan-osipov
left a comment
There was a problem hiding this comment.
minor chnage request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Testing status
Manual testing status
Comments to reviewers