Skip to content

Conversation

@AsakuraMizu
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings December 30, 2025 08:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR attempts to remove the unused heap_bottom field from the ProcessData struct along with its associated getter and setter methods. However, the PR is incomplete as it doesn't remove all usages of these methods in the codebase.

Key changes:

  • Removed heap_bottom field from ProcessData struct in core/src/task.rs
  • Removed get_heap_bottom() and set_heap_bottom() methods from ProcessData
  • Removed one call to set_heap_bottom() in api/src/syscall/task/execve.rs

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
core/src/task.rs Removes the heap_bottom field, its initialization, and associated getter/setter methods from the ProcessData struct
api/src/syscall/task/execve.rs Removes the call to set_heap_bottom() when resetting the heap during execve

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@AsakuraMizu AsakuraMizu merged commit e556238 into main Dec 30, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants