Skip to content

add optimizations#34

Merged
Sammster10 merged 22 commits intomasterfrom
optimize
Mar 8, 2026
Merged

add optimizations#34
Sammster10 merged 22 commits intomasterfrom
optimize

Conversation

@Sammster10
Copy link
Member

@Sammster10 Sammster10 commented Mar 7, 2026

The goal of this PR is to reduce memory allocation rates, and to reduce overall QPS on the H2 db.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 76 out of 76 changed files in this pull request and generated 10 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 76 out of 76 changed files in this pull request and generated 6 comments.

Comments suppressed due to low confidence (1)

core/src/main/java/net/staticstudios/data/parse/SQLColumn.java:67

  • SQLColumn.equals now includes the new virtual field, but hashCode() does not. This violates the equals/hashCode contract and can break use of SQLColumn as a key in hash-based collections (e.g., columns may not be found/updated correctly). Include virtual in hashCode() (and preferably compare it via virtual == other.virtual in equals).
    @Override
    public int hashCode() {
        return Objects.hash(table, type, name, nullable, indexed, unique, defaultValue);
    }

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 77 out of 78 changed files in this pull request and generated 6 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Sammster10 Sammster10 marked this pull request as ready for review March 8, 2026 21:41
@Sammster10 Sammster10 merged commit f406c7d into master Mar 8, 2026
1 check passed
@Sammster10 Sammster10 deleted the optimize branch March 8, 2026 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants