Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 76 out of 76 changed files in this pull request and generated 10 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
core/src/main/java/net/staticstudios/data/query/QueryBuilder.java
Outdated
Show resolved
Hide resolved
intellij-plugin/src/main/java/net/staticstudios/data/ide/intellij/SyntheticBuilderClass.java
Show resolved
Hide resolved
intellij-plugin/src/main/java/net/staticstudios/data/ide/intellij/SyntheticMethod.java
Show resolved
Hide resolved
core/src/main/java/net/staticstudios/data/impl/h2/trigger/H2ReadCacheInvalidatorTrigger.java
Show resolved
Hide resolved
processor/src/main/java/net/staticstudios/data/compiler/javac/javac/ParsedCachedValue.java
Show resolved
Hide resolved
processor/src/main/java/net/staticstudios/data/compiler/javac/javac/ParsedCachedValue.java
Show resolved
Hide resolved
processor/src/main/java/net/staticstudios/data/compiler/javac/javac/QueryBuilderProcessor.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 76 out of 76 changed files in this pull request and generated 6 comments.
Comments suppressed due to low confidence (1)
core/src/main/java/net/staticstudios/data/parse/SQLColumn.java:67
SQLColumn.equalsnow includes the newvirtualfield, buthashCode()does not. This violates the equals/hashCode contract and can break use of SQLColumn as a key in hash-based collections (e.g., columns may not be found/updated correctly). IncludevirtualinhashCode()(and preferably compare it viavirtual == other.virtualinequals).
@Override
public int hashCode() {
return Objects.hash(table, type, name, nullable, indexed, unique, defaultValue);
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
core/src/main/java/net/staticstudios/data/query/BaseQueryWhere.java
Outdated
Show resolved
Hide resolved
core/src/main/java/net/staticstudios/data/impl/h2/trigger/H2ReadCacheInvalidatorTrigger.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 77 out of 78 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
core/src/main/java/net/staticstudios/data/util/SlidingWindowCounter.java
Show resolved
Hide resolved
core/src/main/java/net/staticstudios/data/query/clause/cv/CachedValueInClause.java
Show resolved
Hide resolved
core/src/main/java/net/staticstudios/data/query/clause/cv/CachedValueNotInClause.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to reduce memory allocation rates, and to reduce overall QPS on the H2 db.