Fix/398 dto validation#458
Open
pharwasz wants to merge 3 commits into
Open
Conversation
|
@pharwasz Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Author
|
kindly approve workflow |
Author
|
Hi, pls kindly approve |
pharwasz
force-pushed
the
fix/398-dto-validation
branch
from
bb8944d to
2710238
Compare
Author
|
hello, are you there |
- Replace manual Stellar address regex checks with @IsStellarAddress() - Add @IsUUID() to ID fields referencing UUID primary keys (userId, actorId) - Add @maxlength()/@isnotempty() to text fields across all DTOs - Add @max() bounds to monetary amount fields - Add unit tests for all escrow DTOs - Fix invalid Stellar address test fixtures (wrong length) - Load reflect-metadata globally via jest-setup.js for class-validator
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #398
Adds comprehensive input validation across all DTOs using
class-validatordecorators, ensuring request payloads are properly validated before reaching business logic.Changes
auth.dto.ts,profile.dto.ts) – added validation for email, password strength, and profile fieldsasset.dto.ts) – validated asset creation and update payloadsconsistency-check.dto.ts) – validated admin consistency check inputsvalidators.ts) – added shared custom validator logic with unit testsTests
All DTOs have corresponding
.spec.tsfiles covering valid and invalid input scenarios.