Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "steamgriddb",
"version": "2.2.1",
"version": "2.2.2",
"description": "Node.js Wrapper for the SteamGridDB API",
"main": "dist/index.js",
"types": "dist/index.d.ts",
Expand Down
2 changes: 1 addition & 1 deletion src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ export default class SGDB {
try {
response = await axios(options as AxiosRequestConfig);
} catch (error) {
error.message = error.response.data?.errors?.join(", ") ?? error.message;
error.message = error.response?.data?.errors?.join(", ") ?? error.message;
throw error;
}

Expand Down
39 changes: 39 additions & 0 deletions test/index.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -91,3 +91,42 @@ it("should be deletable", async () => {
const response = await client.deleteGrids([123123]);
expect(response).toBe(true);
});

it("should derive error message from response errors", async () => {
nock("https://www.steamgriddb.com")
.get("/api/v2/games/steam/1234")
.replyWithError({message: "default error msg", response: {data: {errors: ["error_0", "error_1"]}}});

expect.assertions(1);
try {
await client.getGameBySteamAppId(1234);
} catch (e) {
expect(e.message).toEqual("error_0, error_1");
}
});

it("should default to message returned in error", async () => {
nock("https://www.steamgriddb.com")
.get("/api/v2/games/steam/1234")
.replyWithError({message: "default error msg", response: {}});

expect.assertions(1);
try {
await client.getGameBySteamAppId(1234);
} catch (e) {
expect(e.message).toEqual("default error msg");
}
});

it("should handle undefined response object in error", async () => {
nock("https://www.steamgriddb.com")
.get("/api/v2/games/steam/1234")
.replyWithError({message: "default error msg"});

expect.assertions(1);
try {
await client.getGameBySteamAppId(1234);
} catch (e) {
expect(e.message).toEqual("default error msg");
}
});