docs(core-loop): expand with testnet contract deploy + env + on-chain verification#54
Open
ale-helper-bot wants to merge 1 commit into
Open
Conversation
… verification (closes StellarRoute#40)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #40
What
Expands
docs/core-loop.mdwith a "Testnet sequence" section covering thefull merge → on-chain payout loop that the existing "Local sequence" stops
short of.
Sections added
scripts/deploy-contract.shentry point and the underlyingsorobanCLI calls, including expected explorer URL pattern.SOROBAN_RPC_URL,NETWORK_PASSPHRASE,ESCROW_CONTRACT_ID,GATEWAY_SECRET_KEYenv block that flipssubmit_attestationout ofdry-runmode (no moresimulated-tx-*placeholders).program_idsemantics (admin API takes theu64from the contract, not the Postgres UUID).soroban contract invoke ... get_payoutquery, plus the expected match between the two.webhook_events.delivery_idunique constraint and thepayouts.(program_id, pr_number)unique constraint, plus the off-chain balance tracking inload_reward_per_point+increment_milestone_spent.Why
The current
core-loop.mdends at the contract test(
cargo test -p waveflow-escrow record_merge_pays_contributor) which coversfund → register → record_merge without external services. A new contributor
cannot follow a testnet merge → payout end-to-end without reading
scripts/deploy-contract.sh,.env.example, andcrates/gateway/src/attestation.rsseparately. This consolidation lowers thebar for first-time Wave bounty participants and gives maintainers a single
document to link from
docs/PRD.mdSection 6 (operational flow).Acceptance criteria coverage
simulated-vs-real hash behaviour in
attestation.rs::submit_attestationNotes
uses
sorobanCLI commands identical to the actual test setup describedin
scripts/deploy-contract.shand.env.example.mainbranch (commit fetches cleanly withgit fetch upstream).