BRAM support#9
Open
StephenMoreOSU wants to merge 3 commits into
Open
Conversation
StephenMoreOSU
commented
May 19, 2026
StephenMoreOSU
commented
Owner
- Added tests for bram supported in legacy COFFE.
- Modified ERF section of transistor sizing code s.t. sim failures end gracefully.
…ilure and just set a high cost for failing datapoints
…rash during brams
StephenMoreOSU
force-pushed
the
sm-bram-support
branch
from
6f8391e to
f50dd44
Compare
StephenMoreOSU
commented
May 21, 2026
Comment on lines
-1118
to
+1143
| # Get the tfall and trise delays for the inverter from the spice measurements | ||
| tfall = float(spice_meas["meas_" + circuit_element + "_tfall"][0]) | ||
| trise = float(spice_meas["meas_" + circuit_element + "_trise"][0]) | ||
| erf_error = abs((tfall - trise)/tfall) | ||
| # Get the tfall and trise delays for the inverter from the spice measurements. | ||
| # A "failed" value means HSPICE could not measure the .MEAS condition (signal did | ||
| # not cross supply_v/2 in time). Treat as a large delay so the ERF loop bails out | ||
| # via ERF_MAX_ITERATIONS rather than crashing in float(). | ||
| tfall_str = spice_meas["meas_" + circuit_element + "_tfall"][0] | ||
| trise_str = spice_meas["meas_" + circuit_element + "_trise"][0] | ||
| if tfall_str == "failed" or trise_str == "failed": | ||
| tfall = 1.0 | ||
| trise = 1.0 | ||
| erf_error = 1.0 | ||
| else: | ||
| tfall = float(tfall_str) | ||
| trise = float(trise_str) | ||
| erf_error = abs((tfall - trise)/tfall) |
Owner
Author
There was a problem hiding this comment.
For this change, need to add a warning message saying a sim failed, or else this silent failure may cause confusion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.