Fix unused warnings in streaming components#8
Draft
SteveGilvarry wants to merge 2 commits intomasterfrom
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
-D warningsCI policy.Description
src/handlers/hls.rsto use_errand removed unusedHeaderMap/IntoResponseimports.src/streaming/hls/session.rsand simplified theuselist to dropdebug,SegmentInfo, andVideoCodecwhere not required.src/routes/webrtc_native.rsby removing an unusednative_routeslocal variable and keeping the authenticated/public route setup.broadcast_capacityfromZmFifoReaderinsrc/streaming/source/fifo.rsand removedconfigfromWebRtcEngineinsrc/streaming/webrtc/engine.rsto silence dead field warnings.Testing
cargo test --all-features; compilation proceeded but test execution stalled and the run was interrupted before completion.cargo fmtorcargo clippychecks were executed in this change set.Codex Task