Skip to content

fix(api): deterministic correlationId fallback in audit factory #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christopherhouse merged 1 commit into from
Jun 19, 2026
Merged

fix(api): deterministic correlationId fallback in audit factory #86

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion api/BusTerminal.Api/Features/Registry/_Shared/RegistryAuditFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,20 @@ public static AuditEvent Build(
: principal.ObjectId.ToString("D"),
DisplayName: principal?.DisplayName ?? string.Empty);

var correlationId = Activity.Current?.TraceId.ToHexString() ?? string.Empty;
// Spec 006 / FR-042 — correlationId connects audit events to OTel
// traces in App Insights. In production with the AspNetCore OTel
// instrumentation active (auto-wired by `UseAzureMonitor`), the
// ambient Activity always carries a valid trace id. In test mode
// (no AppInsights connection string → no auto-instrumentation) or
// background-job paths without an inbound HTTP request,
// `Activity.Current` can be null. Falling back to an empty string
// was the source of a flaky audit-shape test and a defect for any
// background-emitted audit event. A fresh Guid keeps audit events
// self-correlatable (every event has a non-empty correlationId);
// when an Activity IS present, real cross-system trace linkage
// continues to work.
var correlationId = Activity.Current?.TraceId.ToHexString()
?? Guid.NewGuid().ToString("N");

var summary = parentIsDeprecated
? DeprecatedParentPrefix + changeSummary
Expand Down
Loading