Refactor workflow signatures to typed Pydantic outputs#159
Open
Dan-StrategicAutomation wants to merge 1 commit into
Open
Refactor workflow signatures to typed Pydantic outputs#159Dan-StrategicAutomation wants to merge 1 commit into
Dan-StrategicAutomation wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
agents/schema/base.py:WorkflowResult,MarkdownCompressionRequest, andMarkdownCompressionResult.agents/schema/workflow.py:PlanExecutionResult,TodoResolutionResult,TriagePresentation, andGeneratedAgentSpec, and exported them viaagents/schema/__init__.py.agents/workflow/work_plan_executor.py,agents/workflow/work_todo_executor.py,agents/workflow/triage_agent.py, andagents/workflow/agent_generator.py(now useexecution_result,resolution_result,triage_presentation, andgenerated_agent).utils/knowledge/compression.pyto acceptMarkdownCompressionRequestand returnMarkdownCompressionResult, and updated call sites and callers in workflows to read nested model attributes.tests/test_workflow_signature_models.pyasserting the modified signatures use the new structured Pydantic models and that the models behave as expected.Testing
python -m compileallon the touched modules which succeeded and confirmed there are no syntax errors in the modified files.ruff checkfor the modified files (agents/schema/base.py,agents/schema/workflow.py,agents/schema/__init__.py,agents/workflow/*,utils/knowledge/compression.py,workflows/*, and the new test) and fixed line-length/formatting issues; those checks for the changed files passed.tests/test_workflow_signature_models.pyand compiled them, but fullpytestcould not be executed in this environment due to missing project dependencies (e.g.,pydantic) and network failures when attempting dependency installation.Codex Task