Skip to content

Utilities: single-lookup htmlTags updates in auto-break tag stripping #12647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
niksedk merged 2 commits into from
Jul 19, 2026
+15 −24
Merged

Utilities: single-lookup htmlTags updates in auto-break tag stripping #12647

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
abaf9a4
Utilities: single-lookup htmlTags updates in auto-break tag stripping
ivandrofly Jul 19, 2026
b8c1c81
Utilities: drop the CollectionsMarshal path from AddOrAppendHtmlTag
niksedk Jul 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 15 additions & 24 deletions src/libse/Common/Utilities.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,14 +345,7 @@ public static string AutoBreakLineMoreThanTwoLines(string text, int maximumLengt
{
string tag = s.Substring(six, endIndex - six + 1);
s = s.Remove(six, tag.Length);
if (htmlTags.ContainsKey(six))
{
htmlTags[six] = htmlTags[six] + tag;
}
else
{
htmlTags.Add(six, tag);
}
AddOrAppendHtmlTag(htmlTags, six, tag);
}
else
{
Expand Down Expand Up @@ -434,6 +427,18 @@ public static string AutoBreakLineMoreThanTwoLines(string text, int maximumLengt
return text;
}

private static void AddOrAppendHtmlTag(Dictionary<int, string> htmlTags, int index, string tag)
{
if (htmlTags.TryGetValue(index, out var existing))
{
htmlTags[index] = existing + tag;
}
else
{
htmlTags.Add(index, tag);
}
}

private static string ReInsertHtmlTagsAndCleanUp(string input, Dictionary<int, string> htmlTags)
{
var s = ReInsertHtmlTags(input, htmlTags);
Expand Down Expand Up @@ -604,14 +609,7 @@ public static string AutoBreakLinePrivate(string input, int maximumLength, int m
if (endIndexAssTag > 0)
{
tagString = tagString.Substring(0, endIndexAssTag);
if (htmlTags.ContainsKey(six))
{
htmlTags[six] = htmlTags[six] + tagString;
}
else
{
htmlTags.Add(six, tagString);
}
AddOrAppendHtmlTag(htmlTags, six, tagString);

s = s.Remove(six, endIndexAssTag);
continue;
Expand All @@ -628,14 +626,7 @@ public static string AutoBreakLinePrivate(string input, int maximumLength, int m
{
var tag = s.Substring(six, endIndex - six + 1);
s = s.Remove(six, tag.Length);
if (htmlTags.ContainsKey(six))
{
htmlTags[six] += tag;
}
else
{
htmlTags.Add(six, tag);
}
AddOrAppendHtmlTag(htmlTags, six, tag);
}
else
{
Expand Down