#SBCOSS-446: workflow for code quality check#232
#SBCOSS-446: workflow for code quality check#232HarishGangula merged 8 commits intoSunbird-Ed:release-8.0.0from
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Pull Request Overview
This PR sets up automated code quality checks by introducing linting and testing workflows, ESLint configurations, and necessary scripts/dependencies.
- Add a GitHub Actions workflow to run lint and tests on pull requests
- Configure ESLint (root and project-level) with Angular-specific rules and add a lint target in
angular.json - Update
package.jsonwith lint scripts and ESLint-related dependencies, and add a custom ChromeHeadlessCI launcher in Karma
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| projects/common-form-elements/src/test.ts | Removed obsolete core-js/es7/reflect import |
| projects/common-form-elements/karma.conf.js | Added ChromeHeadlessCI custom launcher for CI test execution |
| projects/common-form-elements/eslint.config.js | New project-level ESLint configuration |
| eslint.config.js | Root ESLint config for TypeScript and Angular templates |
| angular.json | Added lint target and Angular ESLint schematics configuration |
| package.json | Added lint:fix script and ESLint dependencies |
| .github/workflows/pull_request.yml | Workflow to run lint and tests on pull requests |
Comments suppressed due to low confidence (4)
package.json:65
- There is no npm package named
typescript-eslint. You likely intended to add@typescript-eslint/parserand/or@typescript-eslint/eslint-plugininstead.
"typescript-eslint": "8.32.0"
projects/common-form-elements/eslint.config.js:2
- The module
typescript-eslintdoes not exist; update this to@typescript-eslint/eslint-plugin(and configure a parser) or the correct package name.
const tseslint = require("typescript-eslint");
eslint.config.js:3
- Incorrect import: there is no top-level
typescript-eslintpackage. Use@typescript-eslint/eslint-pluginor the appropriate scoped package.
const tseslint = require("typescript-eslint");
.github/workflows/pull_request.yml:20
- Node.js version
22.15.0is not a valid or released version. Consider using a supported LTS (e.g.,18.xor20.x).
node-version: '22.15.0'
No description provided.