SBCOSS-446: updated build file to read version dynamically#235
SBCOSS-446: updated build file to read version dynamically#235HarishGangula merged 2 commits intoSunbird-Ed:release-8.0.0from
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates the mobile build script to pull the package version dynamically from package.json instead of using a hardcoded value.
- Introduced a
getVersion()helper to read and parse the version field. - Replaced the static
'8.0.6'version string with a call togetVersion(). - Defined the
packageFilepathconstant pointing to the shared package manifest.
Comments suppressed due to low confidence (2)
build-mobile.js:7
- The new
getVersionhelper is not covered by any tests; consider adding a unit test to ensure it correctly reads and parses the version frompackage.json.
const getVersion = () => {
build-mobile.js:7
- The script references
fsinsidegetVersion()but does not import it. Addconst fs = require('fs');at the top of the file.
const getVersion = () => {
No description provided.