Use .mjs extensions for ESM#352
Open
rtsao wants to merge 3 commits intoSupremeTechnopriest:masterfrom
Open
Conversation
|
Someone is attempting to deploy a commit to a Personal Account owned by @SupremeTechnopriest on Vercel. @SupremeTechnopriest first needs to authorize it. |
|
Hey @SupremeTechnopriest thank you for the great package. I am also hitting this issue, this package cannot be used in a package that gets imported into nextjs, here is some more context: vercel/next.js#39375 (comment) I tried manually changing to |
1 task
|
Any reason this is not merged yet? 🙏 I'm also hitting this issue when using ESM. |
|
Could we get this merged please 🙏 thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node interprets packages as CommonJS unless package
"type": "module"is declared or.mjsextension is used.This PR resolves this problem by using
.mjsextensions for the ESM bundle.SyntaxError: Cannot use import statement outside a modulewhen importing this package