Skip to content

Conversation

@liquid-metal
Copy link
Contributor

As discussed in #78, we give django a shot - brief comparison with sqlalchemy will follow, though I am already a bit biased :)

This PR tracks my dev branch on the topic for reference, I will remove the draft state when we can think about actually merging. Until then, there will be a million TODO comments

@liquid-metal
Copy link
Contributor Author

The application is in a running state, all features are brought to the django app.
Though for the moment, the code is a mess & there are a number of important todos...
Also, I am missing (and working on) the container setup, removing unused code outside of the django application, tests, docs

Also, there are probably a number of places which do not follow django best practices - I'd suggest to get the application into proper state for release, and shape the model and surrounding code on the go

Before merge to master, I'd also suggest re-generating all migrations, there is no need to keep the initial micro-migrations separate

@Svedrin
Copy link
Owner

Svedrin commented Apr 7, 2025

I'm wondering how best to support existing installations. Maybe slam the existing sql code into the initial migration so that when Django applies it on an existing database, it's basically a no-op, then go from there? 🤔

@liquid-metal
Copy link
Contributor Author

Django has a tool to deal with existing databases, basically generating the initial model and preparing it for the db migrations: https://docs.djangoproject.com/en/5.2/howto/legacy-databases/
As the models in my proposition are the same, just in a slightly different format, I think it is possible to have a migration path - I will add that

@Svedrin
Copy link
Owner

Svedrin commented Aug 28, 2025

@liquid-metal are you still working on this? the PR would still need a lot of cleanup before merging (for instance, code that is moved should be git mved instead of copied).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants