Skip to content

fix: rank_zero logger#1684

Merged
SAKURA-CAT merged 1 commit into
mainfrom
fix/lightning-bugs
Jun 15, 2026
Merged

fix: rank_zero logger#1684
SAKURA-CAT merged 1 commit into
mainfrom
fix/lightning-bugs

Conversation

@Nexisato

Copy link
Copy Markdown
Collaborator

Description

  • fix rank_zero bugs

@Nexisato Nexisato self-assigned this Jun 12, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the PyTorch Lightning integration in swanlab/integration/pytorch_lightning.py by importing and applying the @_rank_zero_experiment decorator to the experiment property, and the @_rank_zero_only decorator to the update_config method. These changes ensure that experiment initialization and configuration updates are properly restricted to the rank-zero process. There are no review comments to address, and no further feedback is required.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@Nexisato Nexisato added the 🐛 bug Something isn't working label Jun 12, 2026
@SAKURA-CAT SAKURA-CAT merged commit 202085a into main Jun 15, 2026
19 checks passed
@SAKURA-CAT SAKURA-CAT deleted the fix/lightning-bugs branch June 15, 2026 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants