Skip to content

fix: git parse url for ssh#1690

Merged
SAKURA-CAT merged 2 commits into
mainfrom
fix/ssh-parser
Jun 29, 2026
Merged

fix: git parse url for ssh#1690
SAKURA-CAT merged 2 commits into
mainfrom
fix/ssh-parser

Conversation

@Nexisato

Copy link
Copy Markdown
Collaborator

Description

  • Fix git parser

@Nexisato Nexisato self-assigned this Jun 23, 2026
@Nexisato Nexisato added the 🐛 bug Something isn't working label Jun 23, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the Git remote URL parsing logic in parse_git_url to normalize SSH scp-like and SSH-with-port URLs into HTTPS format, while also stripping the .git suffix. The unit tests have been updated accordingly. Feedback on the changes suggests handling edge cases where SSH URLs lack a path component to avoid generating trailing slashes, and adding corresponding test cases for these scenarios.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread swanlab/sdk/internal/probe_python/environment/git.py Outdated
Comment thread tests/unit/sdk/internal/probe_python/environment/test_environment_git.py Outdated
@Nexisato Nexisato requested a review from SAKURA-CAT June 23, 2026 07:32
@SAKURA-CAT SAKURA-CAT merged commit df53b8b into main Jun 29, 2026
19 checks passed
@SAKURA-CAT SAKURA-CAT deleted the fix/ssh-parser branch June 29, 2026 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants