Skip to content

fix: filesystem permission check#1692

Merged
SAKURA-CAT merged 1 commit into
mainfrom
fix/non-root-permission
Jun 28, 2026
Merged

fix: filesystem permission check#1692
SAKURA-CAT merged 1 commit into
mainfrom
fix/non-root-permission

Conversation

@Nexisato

Copy link
Copy Markdown
Collaborator

Description

  • fix when user attempts to write to a directory requiring root privileges, no error is thrown, yet no metrics appear on the dashboard.

@Nexisato Nexisato self-assigned this Jun 24, 2026
@Nexisato Nexisato added the 🐛 bug Something isn't working label Jun 24, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request improves error handling during directory creation and run initialization. Specifically, safe_mkdir now immediately raises a PermissionError when permissions are insufficient, preventing misleading timeout errors. Additionally, deliver_run_start is updated to capture and include the original error message in its failure response. Unit tests have been added to verify these behaviors. Feedback is provided to use typing.List instead of the built-in list type hint to maintain compatibility with Python versions older than 3.9.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread swanlab/sdk/protocol/core.py
@Nexisato Nexisato requested a review from SAKURA-CAT June 24, 2026 03:16
@SAKURA-CAT SAKURA-CAT merged commit 2ed6af7 into main Jun 28, 2026
19 checks passed
@Nexisato Nexisato deleted the fix/non-root-permission branch June 29, 2026 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants