feat: set lastInteraction time via session patch and return willHibernateAt #1128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
You can access the deployment of this PR at https://renku-ci-ds-1128.dev.renku.ch |
Pull Request Test Coverage Report for Build 20339056754Details
💛 - Coveralls |
eikek
changed the title
eikek
force-pushed
the
eikek/build/session-last-interaction
branch
from
484ab47 to
cffa1f5
Compare
eikek
force-pushed
the
eikek/build/session-last-interaction
branch
4 times, most recently
from
9d04302 to
4896fd0
Compare
olevski
requested changes
Dec 17, 2025
Member
olevski
left a comment
olevski
left a comment
There was a problem hiding this comment.
Just a few minor changes Eike. All else looks good. We should also test this with the ui changes from SwissDataScienceCenter/renku-ui#3928 from @lorenzo-cavazzi
k8s doesn't allow sub-second resolution
eikek
force-pushed
the
eikek/build/session-last-interaction
branch
from
861ef2d to
d0a2be7
Compare
olevski
previously approved these changes
Dec 18, 2025
Member
|
@eikek can you please hold off on merging this? It will go in renku 2.13.0 but there are things that have not been merged in data services yet that need to go out in 2.12.0. |
olevski
added
the
do not merge
Member
Author
Yes sure, as we discussed. 👍🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
willHibernateAtdate and instead return the newly provided one from amalthealastInteractiontimestamp with the session patch request which is used to update the corresponding session. It is possible to specify either the full (iso) timestamp or usenowthat will resolve to the current time when evaluated at the backend serverRequires the changes in amalthea to be deployed!
/deploy amalthea-sessions=main