Fix CI #444
Merged
Fix CI #444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakebeal
requested changes
Feb 12, 2025
Collaborator
jakebeal
left a comment
jakebeal
left a comment
There was a problem hiding this comment.
Per https://devguide.python.org/versions/ , the current supported Python versions are 3.9 to 3.13. Therefore, rather than pinning to an old version, I believe that we should drop support for 3.7 and 3.8
tcmitchell
reviewed
Feb 12, 2025
tcmitchell
reviewed
Feb 12, 2025
tcmitchell
reviewed
Feb 12, 2025
jakebeal
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes CI badges in README and fixes CI build.
Python 3.7 is no longer included in Ubuntu versions > 22.04 (See actions/setup-python#962). Since our CI matrix was set to use more recent Ubuntu versionw and Python 3.7 was missing, CI was subsequently failing. We subsequently decided to deprecate 3.7 and 3.8 and test for currently supported Python versions 3.9-3.13.