Skip to content

[cmake][ci] Test hub as submodule#52

Draft
hiergaut wants to merge 15 commits intomainfrom
testHubAsSubModule
Draft

[cmake][ci] Test hub as submodule#52
hiergaut wants to merge 15 commits intomainfrom
testHubAsSubModule

Conversation

@hiergaut
Copy link
Copy Markdown
Contributor

@hiergaut hiergaut commented May 2, 2024

Pull Request Desription

Check if you branch history is PR compatible

  • Your branch need to be up to date with origin/main
  • Update your git repository git fetch origin if origin is this remote
  • Check format style with the script provided in scripts/source-format-all.sh
  • You must use clang-format style (github CI version is 11)
  • Your proposal must include a commit where the file CHANGELOG is updated (add a line describing the proposed change + PR id, see file for examples). If your contribution is significant, you can also ask to be added to the contributor list in the discussion.
    These checks are enforced by github workflow actions
    Please refer to the corresponding log in case of failure

UPDATE the form below to describe your PR

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines (see CONTRIBUTING)
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Be aware that the PR request cannot be accepted if it doesn't pass the Continuous Integration tests.

  • What kind of change does this PR introduce?

    • bug fix
    • feature
    • docs update
    • other: CI
  • What is the current behavior? (You can also link to an open issue here)
    Not check performed for project using hub as submodule.

  • What is the new behavior (if this is a feature change)?
    Check hub project as submodule using gh-testAsSubmodule branch

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Other information:

@hiergaut hiergaut added CMake Update cmake files CI Continuous integration (yml files) labels May 2, 2024
@hiergaut hiergaut self-assigned this May 2, 2024
@hiergaut hiergaut marked this pull request as draft May 2, 2024 13:15
@hiergaut hiergaut changed the title [cmake][ci] Test hub as sub module [cmake][ci] Test hub as submodule May 2, 2024
@hiergaut hiergaut force-pushed the testHubAsSubModule branch from 930aa33 to 980fd6b Compare May 2, 2024 14:18
matrix:
config:
- { name: "Ubuntu gcc", os: ubuntu-latest, cc: "gcc", cxx: "g++", hub_static: "ON", hub_shared: "ON" }
# - { name: "Ubuntu gcc", os: ubuntu-latest, cc: "gcc", cxx: "g++", hub_static: "ON", hub_shared: "OFF" }
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will uncomment when rebase from #39 and #49.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Continuous integration (yml files) CMake Update cmake files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant