Skip to content

[ci][cmake] Add clean code ci#55

Open
hiergaut wants to merge 18 commits intomainfrom
addCleanCodeCI
Open

[ci][cmake] Add clean code ci#55
hiergaut wants to merge 18 commits intomainfrom
addCleanCodeCI

Conversation

@hiergaut
Copy link
Copy Markdown
Contributor

Pull Request Desription

Check if you branch history is PR compatible

  • Your branch need to be up to date with origin/main
  • Update your git repository git fetch origin if origin is this remote
  • Check format style with the script provided in scripts/source-format-all.sh
  • You must use clang-format style (github CI version is 11)
  • Your proposal must include a commit where the file CHANGELOG is updated (add a line describing the proposed change + PR id, see file for examples). If your contribution is significant, you can also ask to be added to the contributor list in the discussion.
    These checks are enforced by github workflow actions
    Please refer to the corresponding log in case of failure

UPDATE the form below to describe your PR

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines (see CONTRIBUTING)
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Be aware that the PR request cannot be accepted if it doesn't pass the Continuous Integration tests.

  • What kind of change does this PR introduce?

    • bug fix
    • feature
    • docs update
    • other:
  • What is the current behavior? (You can also link to an open issue here)
    No check of code performed during ci test

  • What is the new behavior (if this is a feature change)?
    Perform clang-format, cppcheck and doxygen compilation checks.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Other information:

@hiergaut hiergaut self-assigned this May 16, 2024
@hiergaut hiergaut marked this pull request as draft May 16, 2024 15:28
@hiergaut
Copy link
Copy Markdown
Contributor Author

All good, ready for review.

@hiergaut
Copy link
Copy Markdown
Contributor Author

Ready to merge.

@hiergaut hiergaut added the TOPULL Pull request to be done firstly label May 16, 2024
@hiergaut hiergaut marked this pull request as ready for review May 16, 2024 16:23
@hiergaut hiergaut added TOPULL #4 Pull request to be done fourthly and removed TOPULL Pull request to be done firstly labels May 16, 2024
@nmellado nmellado removed the TOPULL #4 Pull request to be done fourthly label May 21, 2024
@nmellado nmellado added the TOPULL #3 Pull request to be done thirdly label May 21, 2024
@hiergaut
Copy link
Copy Markdown
Contributor Author

@nmellado ready for review

Comment on lines +72 to +76
# todo please uncomment these above lines when project was fully formated
# - name: Format
# run: cmake --build ${{github.workspace}}/build --target hub-format
# && git diff --exit-code

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still needed ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed when #27 pushing

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file coming from another project ?
If yes, please add source + check licence.

Copy link
Copy Markdown
Contributor Author

@hiergaut hiergaut Jun 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Findcppcheck.cmake line 20-28 :

# 2009-2010 Ryan Pavlik <rpavlik@iastate.edu> <abiryan@ryand.net>
# http://academic.cleardefinition.com
# Iowa State University HCI Graduate Program/VRAC
#
# Copyright Iowa State University 2009-2010.
# Distributed under the Boost Software License, Version 1.0.
# (See accompanying file LICENSE_1_0.txt or copy at
# https://www.boost.org/LICENSE_1_0.txt)```

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems compatible with MPL

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Boost Software License - Version 1.0 - August 17th, 2003

Permission is hereby granted, free of charge, to any person or organization
obtaining a copy of the software and accompanying documentation covered by
this license (the "Software") to use, reproduce, display, distribute,
execute, and transmit the Software, and to prepare derivative works of the
Software, and to permit third-parties to whom the Software is furnished to
do so, all subject to the following:

The copyright notices in the Software and this entire statement, including
the above license grant, this restriction and the following disclaimer,
must be included in all copies of the Software, in whole or in part, and
all derivative works of the Software, unless such copies or derivative
works are solely in the form of machine-executable object code generated by
a source language processor.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE, TITLE AND NON-INFRINGEMENT. IN NO EVENT
SHALL THE COPYRIGHT HOLDERS OR ANYONE DISTRIBUTING THE SOFTWARE BE LIABLE
FOR ANY DAMAGES OR OTHER LIABILITY, WHETHER IN CONTRACT, TORT OR OTHERWISE,
ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
DEALINGS IN THE SOFTWARE.

@hiergaut hiergaut added TOPULL Pull request to be done firstly and removed TOPULL #3 Pull request to be done thirdly labels Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

TOPULL Pull request to be done firstly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants