Conversation
|
All good, ready for review. |
|
Ready to merge. |
|
@nmellado ready for review |
| # todo please uncomment these above lines when project was fully formated | ||
| # - name: Format | ||
| # run: cmake --build ${{github.workspace}}/build --target hub-format | ||
| # && git diff --exit-code | ||
|
|
There was a problem hiding this comment.
Is this file coming from another project ?
If yes, please add source + check licence.
There was a problem hiding this comment.
In Findcppcheck.cmake line 20-28 :
# 2009-2010 Ryan Pavlik <rpavlik@iastate.edu> <abiryan@ryand.net>
# http://academic.cleardefinition.com
# Iowa State University HCI Graduate Program/VRAC
#
# Copyright Iowa State University 2009-2010.
# Distributed under the Boost Software License, Version 1.0.
# (See accompanying file LICENSE_1_0.txt or copy at
# https://www.boost.org/LICENSE_1_0.txt)```
There was a problem hiding this comment.
There was a problem hiding this comment.
Seems compatible with MPL
There was a problem hiding this comment.
Boost Software License - Version 1.0 - August 17th, 2003
Permission is hereby granted, free of charge, to any person or organization
obtaining a copy of the software and accompanying documentation covered by
this license (the "Software") to use, reproduce, display, distribute,
execute, and transmit the Software, and to prepare derivative works of the
Software, and to permit third-parties to whom the Software is furnished to
do so, all subject to the following:
The copyright notices in the Software and this entire statement, including
the above license grant, this restriction and the following disclaimer,
must be included in all copies of the Software, in whole or in part, and
all derivative works of the Software, unless such copies or derivative
works are solely in the form of machine-executable object code generated by
a source language processor.
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE, TITLE AND NON-INFRINGEMENT. IN NO EVENT
SHALL THE COPYRIGHT HOLDERS OR ANYONE DISTRIBUTING THE SOFTWARE BE LIABLE
FOR ANY DAMAGES OR OTHER LIABILITY, WHETHER IN CONTRACT, TORT OR OTHERWISE,
ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
DEALINGS IN THE SOFTWARE.
Pull Request Desription
Check if you branch history is PR compatible
git fetch originif origin is this remotescripts/source-format-all.shThese checks are enforced by github workflow actions
Please refer to the corresponding log in case of failure
UPDATE the form below to describe your PR
Please check if the PR fulfills these requirements
Be aware that the PR request cannot be accepted if it doesn't pass the Continuous Integration tests.
What kind of change does this PR introduce?
What is the current behavior? (You can also link to an open issue here)
No check of code performed during ci test
What is the new behavior (if this is a feature change)?
Perform clang-format, cppcheck and doxygen compilation checks.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information: