chore: add generation function and header function for main file#43
Open
vinnyy-afk wants to merge 8 commits intodevelopfrom
Open
chore: add generation function and header function for main file#43vinnyy-afk wants to merge 8 commits intodevelopfrom
vinnyy-afk wants to merge 8 commits intodevelopfrom
Conversation
QuentinNIO
requested changes
Jun 13, 2022
Engine/Log/_main_.env
Outdated
| @@ -1,4 +1,16 @@ | |||
|
|
|||
| #### PROJECT HEADER BLOC | |||
Member
There was a problem hiding this comment.
this is not a "PROJECT HEADER BLOC"
you might only keep HEADER BLOC
Engine/Make/_main_.env
Outdated
|
|
||
| _truefile="$(echo $_truefile | sed "s|^ ||g" | sed "s|$Tools4Dev_PATH/||g" | sed "s/ /|/g" | sed "s|/_main_.env||g")" | ||
|
|
||
| local _index="$(cat $Tools4Dev_PATH/.Ressources/index/private.index $Tools4Dev_PATH/.Ressources/index/public.index \ |
Member
There was a problem hiding this comment.
i don't think it's a good habit to use \ inside $( ) statements
Engine/Make/_main_.env
Outdated
|
|
||
| local _mainFiles="$(cat $Tools4Dev_PATH/.Ressources/index/private.index | cut -d ':' -f1 | rev | cut -d "/" -f 2- | rev | uniq | grep -v "^#")" | ||
| local _truefile="" | ||
| local _FileJson="$Tools4Dev_PATH/Utils/T4D-Plugin-VSCode/snippets/builtinst4d.json" |
Member
There was a problem hiding this comment.
please structure your folder with a better architecture than "EverythingInThatBag" or el famoso "AllinOneFile" :)
you may want to cut by file or Type Like Engine/Source/ etc.
Engine/Make/_main_.env
Outdated
| fi | ||
| done | ||
|
|
||
| _truefile="$(echo $_truefile | sed "s|^ ||g" | sed "s|$Tools4Dev_PATH/||g" | sed "s/ /|/g" | sed "s|/_main_.env||g")" |
Member
There was a problem hiding this comment.
why do you need to | sed "s/ /|/g" ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.