Skip to content

GH-245/FP-1097: v1–v2 Migration Stylesheet (via Core)#249

Closed
wesleyboar wants to merge 15 commits intomainfrom
task/GH-245-fix-cepv1-style-migration
Closed

GH-245/FP-1097: v1–v2 Migration Stylesheet (via Core)#249
wesleyboar wants to merge 15 commits intomainfrom
task/GH-245-fix-cepv1-style-migration

Conversation

@wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Jun 4, 2021 •
edited
Loading

Important

See #274 instead.

To Do

Done

Frontera:

3Dem:

  • Test on 3dem stage (via snippet, since removed).
  • Test on 3dem prod (via snippet).
  • (41b521d) Add stylesheet to neuronex-cms.
  • Test locally (no snippet).
  • Test on 3dem stage (no snippet).

Other:

  • Author PR.

After Initial Peer Review:

Overview

Add optional stylesheet to fix styling issues faced by all v1 to v2 CMS migrations.

Issues

Changes

  • Docs: Add instructions to main Readme for migration.
  • Docs: Add migrate.*.css description to CSS Readme.
  • Docs: Add CSS _migrations Readme.
  • New: Add CSS _migrations stylesheets.
  • New: Update Frontera assets accordingly:
    • Remove old migration stylesheets.
    • Add small Frontera-specific migration stylesheets.
    • Load new migration stylesheets (Core & Frontera).
  • New: Update Neuronex/3Dem assets accordingly:
    • Load new migration stylesheet (Core).

Screenshots

Homepage
Paragraph Font Size

Testing

Changes

  1. Dropdown font size should be:

    • 16px

  2. Paragraph font size should be:

    • 15px
    • applied last by migrate.v1_v2.css
    • (Frontera*) have two less overrides than on Production

    Screenshots

  3. All style should match between:

    • of 3Dem Staging and 3Dem Prod
    • of Frontera Dev* and Frontera Prod

    on all pages.

    Obvious failures would be…
    • heading font size
    • heading font-family
    • spacing between content
    • header styles

* During your test, Frontera Dev may be running another branch (such as dev for #259).

Built Output

  1. Test .env as CUSTOM_ASSET_DIR=frontera-cms and run npm run build…

    Expect no errors. Expect the following CSS build file output:

    Output taccsite_custom/…/static/…/css/build/migrate.v1_v2.css 
    (...)
/*!
* bootswatch v3.3.7
(...)
*/
/*!
* Bootstrap v3.3.7 (http://getbootstrap.com)
(...)
*/
/*! normalize.css v3.0.3 (...) */(...)
/*!
* AngularJS Material Design
(...)
*/(...)
/*!
* CoreV1 Portal Stylesheet `portal.css`
(...)
*/(...)
/*!
* CoreV1 Portal Stylesheet `frontera.css`
(...)
*/(...)

  2. Test .env as the following and run npm run build…

    • CUSTOM_ASSET_DIR=example-cms
    • CUSTOM_ASSET_DIR=a2cps-cms
    • CUSTOM_ASSET_DIR=neuronex-cms

    Expect no errors. Expect the following CSS build file output:

    taccsite_custom/…/static/…/css/build/migrate.v1_v2.css 
    (...)
/*!
* bootswatch v3.3.7
(...)
*/
/*!
* Bootstrap v3.3.7 (http://getbootstrap.com)
(...)
*/
/*! normalize.css v3.0.3 (...) */(...)
/*!
* AngularJS Material Design
(...)
*/(...)
/*!
* CoreV1 Portal Stylesheet `portal.css`
(...)
*/(...)

Notes

Snippets

For Sites Migrated Before GH-245 (Frontera)

Pros:

Cons:

NAME:

GH-245: CSS: Temp. Fix Migration Style Discrepancies

HTML:
<style type="text/css">
/* TODO: After GH-245 is merged and deployed to this site, remove this code */
/* FAQ: To make `1rem` equal the size that CoreV2 CMS Bootstrap expects */
/* FAQ: This fixes things like:
        - Dropdown Font Size (in 2020– header design)
*/
/* !!!: Do NOT unset <html> font size on Frontera */
/* FAQ: Frontera homepage redesign relies on its `html { font-size: 10px }` */
/*
html { font-size: unset; }
*/
.s-header .dropdown-menu { font-size: 16px; }
</style>
SLUG:

gh-245-css-temp-fix-migration-style-discrepancies

For Sites Migrated During/After GH-245 (3Dem.org, etc.)

Pros:

Cons:

NAME:

GH-245: CSS: Migration Stylesheet CoreV1 to CoreV2 (last commit: …)

HTML:
<style type="text/css">
/* … *//* FAQ: Copy the content of the built file `taccsite_cms/static/site_cms/css/build/migrate.v1_v2.css` */
</style>
SLUG:

gh-245-css-migration-stylesheet-corev1-corev2

@wesleyboar wesleyboar marked this pull request as draft June 4, 2021 23:19
@wesleyboar wesleyboar added bug Something isn't working effort M Medium effort task (~1 week) — does not include review time feature A new feature or replacement of present feature paused Started but not actively in progress priority ━ Medium priority labels Jun 7, 2021
This was linked to issues Jun 15, 2021
Fix CEPv1 Migration Style Discrepancies #245
Closed
Global Layout / Spacing Styles #99
Closed
Global Typography Styles & Fonts #98
Closed
This was unlinked from issues Jun 15, 2021
Global Typography Styles & Fonts #98
Closed
Global Layout / Spacing Styles #99
Closed
@wesleyboar wesleyboar linked an issue Jun 15, 2021 that may be closed by this pull request
Global Typography Styles & Fonts #98
Closed
@wesleyboar wesleyboar added priority ▲▲ Very high priority and removed bug Something isn't working effort M Medium effort task (~1 week) — does not include review time feature A new feature or replacement of present feature priority ━ Medium priority paused Started but not actively in progress labels Jul 3, 2021
@wesleyboar wesleyboar mentioned this pull request Jul 6, 2021
Closed
@wesleyboar wesleyboar changed the base branch from main to dev July 6, 2021 20:13
@wesleyboar wesleyboar force-pushed the task/GH-245-fix-cepv1-style-migration branch from 0c9dbf5 to 41b521d Compare July 6, 2021 20:39
@wesleyboar wesleyboar changed the base branch from dev to main July 6, 2021 20:39
@wesleyboar wesleyboar marked this pull request as ready for review July 6, 2021 21:24
@wesleyboar wesleyboar changed the title GH-245: v1–v2 Migration Stylesheet (and Frontera Updated to Use Them) GH-245: v1–v2 Migration Stylesheet (and Frontera and 3Dem Using Them) Jul 6, 2021
@wesleyboar wesleyboar changed the title GH-245: v1–v2 Migration Stylesheet (and Frontera and 3Dem Using Them) GH-245/FP-1097: v1–v2 Migration Stylesheet (use on Frontera & 3Dem) Jul 6, 2021
@wesleyboar wesleyboar marked this pull request as draft July 7, 2021 18:31
@wesleyboar
Copy link
Member Author

wesleyboar commented Jul 7, 2021

After Initial Peer Review
Move code out of Core via Fix CEPv1 Migration Style Discrepancies Core-CMS-Resources#56.

@wesleyboar wesleyboar marked this pull request as ready for review July 9, 2021 19:22
@wesleyboar wesleyboar mentioned this pull request Jul 9, 2021
Merged
5 tasks
@wesleyboar wesleyboar changed the title GH-245/FP-1097: v1–v2 Migration Stylesheet (use on Frontera & 3Dem) GH-245/FP-1097: v1–v2 Migration Stylesheet (via Core) Jul 9, 2021
@wesleyboar
Copy link
Member Author

wesleyboar commented Jul 9, 2021 •
edited
Loading

Closed (because of FP-1112) in favor of #274.

@wesleyboar wesleyboar closed this Jul 9, 2021
@wesleyboar wesleyboar deleted the task/GH-245-fix-cepv1-style-migration branch July 13, 2021 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

priority ▲▲ Very high priority

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix CEPv1 Migration Style Discrepancies Global Typography Styles & Fonts

1 participant

@wesleyboar