Merged
Conversation
This was referenced Jul 28, 2022
wesleyboar
added a commit
to TACC/tup-ui
that referenced
this pull request
Jul 29, 2022
wesleyboar
added a commit
to TACC/tup-ui
that referenced
this pull request
Jul 29, 2022
Fractal start does not work, but build does, so just serve the dist.
wesleyboar
added a commit
to TACC/Core-Styles
that referenced
this pull request
Jul 29, 2022
This was referenced Jul 29, 2022
wesleyboar
commented
Aug 3, 2022
Member
Author
wesleyboar
left a comment
wesleyboar
left a comment
There was a problem hiding this comment.
The future intent—if we still don't have storybook yet (pending a snag in tup-ui using it for components)—is that a Dockerfile is added so this can be hosted properly as a custom app.
rstijerina
approved these changes
Aug 16, 2022
Member
rstijerina
left a comment
rstijerina
left a comment
There was a problem hiding this comment.
LGTM, nice work. Any reason why the close x's look italicized?
Member
Author
@rstijerina Thank you. Yes.
When I add cortal icons to Core-Styles, I can make that a Cortal icon. Alternatively—to truly isolate modules (not mix cortal icons into button)—I could turn off the italic style for just that pattern and only in the pattern demo. Hm, I like that. Be right back. |
Member
Author
|
Fixed italics on pseudo-icons: |
wesleyboar
added a commit
to TACC/Core-Styles
that referenced
this pull request
Aug 16, 2022
* feat: fp-1499, core-styles pattern demo * feat: updates from tup-ui (except paths) TACC/tup-ui@a30002a TACC/tup-ui@24db51b TACC/tup-ui@141464f P.S. a30002a originates from TACC/tup-ui#38 * fix: fp-1726 allow int. + ext. global css * feat(core-styles): fp-1499 drop excess file affix No need for `-css` on build and test scripts. * feat(core-styles): fp-1499 tarball for TACC/Core-CMS#527 * feat(core-styles): fp-1726 c-button, a tag support * chore(core-styles): fp-1499 remove tarball * chore: fp-1499 add node version to readme * fix: fp-1499 no italics for pseuo-icons
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Add UI Pattern Demo using Fractal.
To Do
Related
requires Task/fp 1499 core-styles demo tup-ui#45requires feat: fp-1499 ui pattern demo Core-Styles#34
Changes
Testing
npm cinpm run build --project=core-cms(requires a project e.g.
core-cms,ecep-cms,frontera-cms)npm run start:css-demoCommand name suggestions are welcome.
UI
No remote server available. Pending new architecture.
Screenshots
Fixes
no italics for pseudo-icons (TACC/Core-Styles@
474eff3)Notes
Known Issues
1. When we have a way to deploy, we might drop the ability to support building per project…
…because the symlink-ed
styles/projectsdirectory includes many irrelevant files (.py,.md,.html).The feature could come back if and after Core-CMS-Resources become their own containerized projects.