Draft
Conversation
So that it can be loaded from CDN. Use cases are: - if search template is broken - for custom search page - for non-Core website
Compared to "cms-search", "google-search" is: - more accurate - more obvious to those not familiar with Core-CMS
So dev sees 'google-search' from CSS before seeing it in HTML `id` attr.
Caused server error.
This had create dbreadcrumsb before.
Final markup undecided, so keep it simple, and easy to understand.
* fix: inaccurate text picture template name * fix: show value if old template is in use
* feat: support core-styles u-image-zoom * feat: support core-styles u-image-zoom via script * Revert "feat: support core-styles u-image-zoom via script" This reverts commit 2a15a75. * feat: support zoom_effect + no_link_to_image * refactor: only load css once from multiple tries * refactor: extract link & figure start to templates * refactor: rebuild zoom templates to strip classes * feat: template tag `strip_class_attribute` * fix: strip_class_attribute munges data-class test * fix: template name/path typo * fix: all picture template bugs i think * docs: add help_text to Picture template field * feat: overwrite bs4 picture plugin validation * fix: strip_class_attr… regex munges `data-class` * test: highlight unsupported figure image zoom * fix: u-image-zoom-- class not added * fix: sometimes span missing & class in wrong spot * fix: core-styles zoom bug * enhance: clearer debuging ui * refactor: template logic → custom view context * Revert "refactor: template logic → custom view context" This reverts commit a123568.
* feat: support core-styles u-image-zoom * feat: support core-styles u-image-zoom via script * Revert "feat: support core-styles u-image-zoom via script" This reverts commit 2a15a75. * feat: support zoom_effect + no_link_to_image * refactor: only load css once from multiple tries * refactor: extract link & figure start to templates * refactor: rebuild zoom templates to strip classes * feat: template tag `strip_class_attribute` * fix: strip_class_attribute munges data-class test * fix: template name/path typo * fix: all picture template bugs i think * docs: add help_text to Picture template field * feat: overwrite bs4 picture plugin validation * fix: strip_class_attr… regex munges `data-class` * test: highlight unsupported figure image zoom * fix: u-image-zoom-- class not added * fix: sometimes span missing & class in wrong spot * fix: core-styles zoom bug * enhance: clearer debuging ui * refactor: template logic → custom view context * Revert "refactor: template logic → custom view context" This reverts commit a123568. * refactor: template logic → custom view context * fix: bad/old path to zoom asset * refactor: move css snippet to stylehseet * refactor: rename test stylesheet * fix: test stylesheet too specific * fix: a lot, and simplify * refactor!: revert template names * fix: final bugs * chore: remove excess new line * refactor: simplify templates and update comments
* deps: core-styles v2.46.1 * refactor: u-image-zoom via core-styles
* fix: space under span.u-image-zoom img * deps: core-styles v2.46.2
* feat: snippet to redirect external article * fix: load Core-CMS script not tup-ui script
Member
Author
|
Reviewers removed for now. Important Incomplete because there is a suggestion (which I agree with) to use a custom migration. |
wesleyboar
added a commit
to TACC/CTRN-CMS
that referenced
this pull request
Jan 27, 2026
CTRN had used (unmerged) TACC/Core-CMS#885. That means it has remnant code of a search_page app.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Support a Google Search page with less effort.
What Effort?
Every Time:
code→ ID.SEARCHsettings.Previously:
/searchpage.Now, Instead:
Important
Incomplete because there is a suggestion (which I agree with) to use a custom migration.
Caution
Do not merge.
Warning
Successful run requires two deploys. Help wanted.
Related
Instances:
Private, so no results.
Private, but has results from public LCCF.
Private still, so no results.
Changes
search_pageappSEARCH_AUTO_SETUPsettingGOOGLE_SEARCH_ENGINE_IDsettingTesting
GOOGLE_SEARCH_ENGINE_IDsetting e.g.GOOGLE_SEARCH_ENGINE_ID = 'b099996c09ebd4ece'SEARCH_AUTO_SETUP = Truesetting.GOOGLE_SEARCH_ENGINE_IDsetting.UI
GOOGLE_SEARCH_ENGINE_IDGOOGLE_SEARCH_ENGINE_ID