FP-557: New <dl> (Description/Definition List) Component#116
Merged
wesleyboar merged 12 commits intomasterfrom Jul 31, 2020
Merged
FP-557: New <dl> (Description/Definition List) Component#116wesleyboar merged 12 commits intomasterfrom
<dl> (Description/Definition List) Component#116wesleyboar merged 12 commits intomasterfrom
Conversation
1 task
Codecov Report
@@ Coverage Diff @@
## master #116 +/- ##
==========================================
+ Coverage 55.02% 55.10% +0.07%
==========================================
Files 220 222 +2
Lines 7767 7785 +18
Branches 1081 1083 +2
==========================================
+ Hits 4274 4290 +16
- Misses 3289 3291 +2
Partials 204 204
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Member
Author
|
I keep getting an e-mail reporting Client Side Unit Tests failure. I call BS on CodeCov… it won't load the log and local |
jchuahtacc
approved these changes
Jul 31, 2020
Contributor
jchuahtacc
left a comment
There was a problem hiding this comment.
Looks great! Can't wait to use it.
This was referenced Aug 4, 2021
<dl> Component<dl> (Description/Definition List) Component
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview:
New component to:
#cep-designthread)PR Status:
Related Jira tickets:
Summary of Changes:
composesto pass CSS linter.Testing Steps:
UI Photos:
P.S. I found no discernible difference between browsers. 2021-08: I found a discernible difference. Firefox supports truncation via character (like ":"), but other browsers do not. This caveat is mentioned on TACC/Core-CMS#305.
Notes: