Conversation
* FP-515: Add Icon component from FP-354
* FP-515: Add Icon component usage from FP-354
* FP-515: Install Cortal 1.2
- Disable linting of `icon.fonts.css`.
- Support WOFF in Webpack config.
- Update several files (and tests) to use new icon names:
- AppIcon
- AppBrowser
- DataFilesListingCell
- DataFilesSidebar
- DataFilesToolbar
- Sidebar
- TicketModal
- Replace old Core Portal font with Cortal Icons font.
- Migrate font styles to their own stylesheet.
- Add icon aliases:
- icon-collapse (icon-contract)
* FP-515: Disable an "extra icon"
Codecov Report
@@ Coverage Diff @@
## master #131 +/- ##
=======================================
Coverage 55.11% 55.11%
=======================================
Files 222 222
Lines 7786 7786
Branches 1084 1084
=======================================
Hits 4291 4291
Misses 3291 3291
Partials 204 204
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Member
Author
|
See #132, instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closed
In favor of #132. The two other sub-tasks that were gonna be done have been moved to Safehold.
Overview:
Remaining work from sub-tasks of FP-228 (which might instead have smaller independent PRs).
PR Status:
Related Jira tickets:
Summary of Changes:
(pending)
Testing Steps:
UI Photos:
(pending)
Notes:
(pending)