-
Notifications
You must be signed in to change notification settings - Fork 7
Guided onboarding tour #358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for harp-plugin canceled.
|
cwitkowitz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work Saumya! This will be extremely helpful for new users.
A few comments:
- Upon startup, there appears to be an assertion failure
JUCE Assertion failure in juce_ResizableWindow.cpp:687
coming from line 55 in WelcomeWindow.h
addAndMakeVisible(&titleLabel);
I reset my settings completely, so I'm not sure if that has something to do with it. - The "Learn more" label is cut off for me.
- I'm not sure if we should be forcing a default model upon HARP startup. Maybe after finishing or exiting the tutorial, we could reset the model tab.
- I can foresee potential issues with using a ZeroGPU model as the default within the tutorial.
- I removed the code for the legacy settings key. I don't think that will be much of an issue going forward.
- When clicking "Skip Tutorial", the user is brought to the final page of the tutorial, rather than having it close right away. Should this button behave like the X button? Should we have the button along with the "don't show this again" check box on each tutorial page?
- The tutorial could include some information on the media clipboard, such as adding, selecting, removing, renaming, and send-to-DAW).
- There could also be some information on saving output tracks manually vs. dragging/dropping them to the DAW vs. using the send-to-DAW functionality.
Thank you for the feedback! 1, 2. I had not run into those issues, but will try to reproduce this with a clean settings reset and add a guard. Also, "learn more" could be related to layout or scaling differences, so thanks for flagging that.
7,8. Both sound good to me, and will add a small brief the media clipboard and output tracks saving. |
No description provided.