Skip to content

Conversation

@saumya-pailwan
Copy link
Collaborator

No description provided.

@netlify
Copy link

netlify bot commented Jan 6, 2026

Deploy Preview for harp-plugin canceled.

Name Link
🔨 Latest commit 236e41c
🔍 Latest deploy log https://app.netlify.com/projects/harp-plugin/deploys/6973d9d5919d2c0008b9fec3

@saumya-pailwan saumya-pailwan changed the title welcome popup update Guided onboarding tour Feb 1, 2026
@cwitkowitz cwitkowitz changed the base branch from main to develop February 4, 2026 14:49
@cwitkowitz cwitkowitz linked an issue Feb 6, 2026 that may be closed by this pull request
Copy link
Collaborator

@cwitkowitz cwitkowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Saumya! This will be extremely helpful for new users.

A few comments:

  1. Upon startup, there appears to be an assertion failure
    JUCE Assertion failure in juce_ResizableWindow.cpp:687
    coming from line 55 in WelcomeWindow.h
    addAndMakeVisible(&titleLabel);
    I reset my settings completely, so I'm not sure if that has something to do with it.
  2. The "Learn more" label is cut off for me.
  3. I'm not sure if we should be forcing a default model upon HARP startup. Maybe after finishing or exiting the tutorial, we could reset the model tab.
  4. I can foresee potential issues with using a ZeroGPU model as the default within the tutorial.
  5. I removed the code for the legacy settings key. I don't think that will be much of an issue going forward.
  6. When clicking "Skip Tutorial", the user is brought to the final page of the tutorial, rather than having it close right away. Should this button behave like the X button? Should we have the button along with the "don't show this again" check box on each tutorial page?
  7. The tutorial could include some information on the media clipboard, such as adding, selecting, removing, renaming, and send-to-DAW).
  8. There could also be some information on saving output tracks manually vs. dragging/dropping them to the DAW vs. using the send-to-DAW functionality.

@saumya-pailwan
Copy link
Collaborator Author

Great work Saumya! This will be extremely helpful for new users.

A few comments:

  1. Upon startup, there appears to be an assertion failure
    JUCE Assertion failure in juce_ResizableWindow.cpp:687
    coming from line 55 in WelcomeWindow.h
    addAndMakeVisible(&titleLabel);
    I reset my settings completely, so I'm not sure if that has something to do with it.
  2. The "Learn more" label is cut off for me.
  3. I'm not sure if we should be forcing a default model upon HARP startup. Maybe after finishing or exiting the tutorial, we could reset the model tab.
  4. I can foresee potential issues with using a ZeroGPU model as the default within the tutorial.
  5. I removed the code for the legacy settings key. I don't think that will be much of an issue going forward.
  6. When clicking "Skip Tutorial", the user is brought to the final page of the tutorial, rather than having it close right away. Should this button behave like the X button? Should we have the button along with the "don't show this again" check box on each tutorial page?
  7. The tutorial could include some information on the media clipboard, such as adding, selecting, removing, renaming, and send-to-DAW).
  8. There could also be some information on saving output tracks manually vs. dragging/dropping them to the DAW vs. using the send-to-DAW functionality.

Thank you for the feedback!

1, 2. I had not run into those issues, but will try to reproduce this with a clean settings reset and add a guard. Also, "learn more" could be related to layout or scaling differences, so thanks for flagging that.

  1. Open to adjusting this, kept it open after completion as can be useful for quick testing by new users. That said, it also makes sense to reset.

  2. Regarding the ZeroGPU issues, this is something I was also thinking about. But, so far, demucs has been the easiest for new users to understand and use compared to other Hugging Face models.
    Stability AI models are better for defaults, but we have seen feedback that the prompting can be confusing and demos do not always work as expected. So, I did not use them, but we can discuss this.

  3. Thanks for handling that.

  4. Here, I intentionally brought it to the last page so users do not miss adding tokens in the settings tab, but I agree that closing makes more sense as a first time user wont skip. I will change this.

7,8. Both sound good to me, and will add a small brief the media clipboard and output tracks saving.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Welcome Popup for New Users

2 participants