Skip to content

Catch and print IllegalArgumentException and continue registering. #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bnouwt merged 1 commit into from
Jan 23, 2026
Merged

Catch and print IllegalArgumentException and continue registering. #785

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 24 additions & 8 deletions smart-connector/src/main/java/eu/knowledge/engine/smartconnector/util/KnowledgeBaseImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,26 +503,42 @@ public synchronized void syncKIs() {
throw new IllegalStateException("The KB should be started before registering KIs.");

for (var ki : this.registeredAskKIs) {
this.getSC().register(ki);
this.currentAskKIs.add(ki);
try {
this.getSC().register(ki);
this.currentAskKIs.add(ki);
} catch (IllegalArgumentException iae) {
LOG.error("Registering KI {} should succeed.", ki, iae);
}
}
this.registeredAskKIs.clear();

for (var entry : this.registeredAnswerKIs.entrySet()) {
this.getSC().register(entry.getKey(), entry.getValue());
this.currentAnswerKIs.put(entry.getKey(), entry.getValue());
try {
this.getSC().register(entry.getKey(), entry.getValue());
this.currentAnswerKIs.put(entry.getKey(), entry.getValue());
} catch (IllegalArgumentException iae) {
LOG.error("Registering KI {} should succeed.", entry.getKey(), iae);
}
}
this.registeredAnswerKIs.clear();

for (var ki : this.registeredPostKIs) {
this.getSC().register(ki);
this.currentPostKIs.add(ki);
try {
this.getSC().register(ki);
this.currentPostKIs.add(ki);
} catch (IllegalArgumentException iae) {
LOG.error("Registering KI {} should succeed.", ki, iae);
}
}
this.registeredPostKIs.clear();

for (var entry : this.registeredReactKIs.entrySet()) {
this.getSC().register(entry.getKey(), entry.getValue());
this.currentReactKIs.put(entry.getKey(), entry.getValue());
try {
this.getSC().register(entry.getKey(), entry.getValue());
this.currentReactKIs.put(entry.getKey(), entry.getValue());
} catch (IllegalArgumentException iae) {
LOG.error("Registering KI {} should succeed.", entry.getKey(), iae);
}
}
this.registeredReactKIs.clear();

Expand Down