[TASK] Realign runTests.sh code with Core version of the file#1981
Merged
oliverklee merged 1 commit intomainfrom Mar 2, 2026
Merged
Conversation
3 tasks
oliverklee
changed the title
runTests.sh code with Core version of the file
oliverklee
added this to the
4.0.0: Drop support for TYPO3 11LTS and PHP 7.4/8.0, add support for 13LTS milestone
oliverklee
requested changes
Mar 2, 2026
Pull Request Test Coverage Report for Build 22585652786Details
💛 - Coveralls |
cumuru
force-pushed
the
task/1841-align-our-runtestssh-with-the-core-instance-more
branch
from
c1587fd to
fba99d4
Compare
cumuru
force-pushed
the
task/1841-align-our-runtestssh-with-the-core-instance-more
branch
from
fba99d4 to
625e26c
Compare
cumuru
force-pushed
the
task/1841-align-our-runtestssh-with-the-core-instance-more
branch
from
625e26c to
ce39651
Compare
oliverklee
approved these changes
Mar 2, 2026
After some discussion we decided to accept some shell issues in order to ease copying code from the core‘s version of runTests.sh. That means that shell fixes applied earlier had to be reverted. Commands affected: * composer * functional * npm Relates: #1841
cumuru
force-pushed
the
task/1841-align-our-runtestssh-with-the-core-instance-more
branch
from
ce39651 to
f29e903
Compare
oliverklee
approved these changes
Mar 2, 2026
oliverklee
deleted the
task/1841-align-our-runtestssh-with-the-core-instance-more
branch
github-project-automation
bot
moved this from In Review
to Done
in Best Practices Remote Day
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After some discussion we decided to accept some shell issues in order to ease copying code from the core‘s version of runTests.sh. That means that shell fixes applied earlier had to be reverted. Commands affected:
Please note that the shell check suppression that I had to introduce is now defined at the very top of the
runTests.sh. That way we could still have our own shell scripts with stricter rules but don‘t have to insert
line suppression directives when copying over core code inside this file.
My suggestion is to streamline the suppression in a follow up issue (as there are now three locations:
file level suppression, line level suppression and via environment variable in the container run command.
Part of #1841