Skip to content

fix(sidebar): prevent clear button (X) from overlapping scrollbar in table filter #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
debba merged 1 commit into from
Jul 1, 2026
+6 −6
Merged

fix(sidebar): prevent clear button (X) from overlapping scrollbar in table filter #403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/layout/ExplorerSidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1432,12 +1432,12 @@ export const ExplorerSidebar = ({ sidebarWidth, startResize, onCollapse, sidebar
value={tableFilter}
onChange={(e) => setTableFilter(e.target.value)}
placeholder={t("sidebar.filterTables")}
className="w-full bg-surface-secondary text-xs text-secondary placeholder:text-muted rounded pl-6 pr-6 py-1 border border-default focus:outline-none focus:border-blue-500/50"
className="w-full bg-surface-secondary text-xs text-secondary placeholder:text-muted rounded pl-6 pr-10 py-1 border border-default focus:outline-none focus:border-blue-500/50"
/>
{tableFilter && (
<button
onClick={() => setTableFilter("")}
className="absolute right-1.5 text-muted hover:text-primary"
className="absolute right-3 top-1/2 -translate-y-1/2 text-muted hover:text-primary p-0.5 rounded hover:bg-surface-secondary"
>
<X size={11} />
</button>
Expand Down
4 changes: 2 additions & 2 deletions src/components/layout/sidebar/SidebarDatabaseItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,13 +268,13 @@ export const SidebarDatabaseItem = ({
value={tableFilter}
onChange={(e) => setTableFilter(e.target.value)}
placeholder={t("sidebar.filterTables")}
className="w-full bg-surface-secondary text-xs text-secondary placeholder:text-muted rounded pl-6 pr-6 py-1 border border-default focus:outline-none focus:border-blue-500/50"
className="w-full bg-surface-secondary text-xs text-secondary placeholder:text-muted rounded pl-6 pr-10 py-1 border border-default focus:outline-none focus:border-blue-500/50"
onClick={(e) => e.stopPropagation()}
/>
{tableFilter && (
<button
onClick={(e) => { e.stopPropagation(); setTableFilter(""); }}
className="absolute right-1.5 text-muted hover:text-primary"
className="absolute right-3 top-1/2 -translate-y-1/2 text-muted hover:text-primary p-0.5 rounded hover:bg-surface-secondary"
>
<X size={11} />
</button>
Expand Down
4 changes: 2 additions & 2 deletions src/components/layout/sidebar/SidebarSchemaItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,13 +218,13 @@ export const SidebarSchemaItem = ({
value={tableFilter}
onChange={(e) => setTableFilter(e.target.value)}
placeholder={t("sidebar.filterTables")}
className="w-full bg-surface-secondary text-xs text-secondary placeholder:text-muted rounded pl-6 pr-6 py-1 border border-default focus:outline-none focus:border-blue-500/50"
className="w-full bg-surface-secondary text-xs text-secondary placeholder:text-muted rounded pl-6 pr-10 py-1 border border-default focus:outline-none focus:border-blue-500/50"
onClick={(e) => e.stopPropagation()}
/>
{tableFilter && (
<button
onClick={(e) => { e.stopPropagation(); setTableFilter(""); }}
className="absolute right-1.5 text-muted hover:text-primary"
className="absolute right-3 top-1/2 -translate-y-1/2 text-muted hover:text-primary p-0.5 rounded hover:bg-surface-secondary"
>
<X size={11} />
</button>
Expand Down