Added signature verification support for SMB2 client#300
Added signature verification support for SMB2 client#300cri-triovega wants to merge 1 commit intoTalAloni:masterfrom
Conversation
|
First of all, thanks for the contribution! With that said, I need to carefully check the implementation to make sure it does not introduce any regression, I will try to find time for a deeper review in the coming weeks. Thanks again. |
093b856 to
5c5c764
Compare
d8327d6 to
4910252
Compare
|
Apologies for taking such a long time to get to this. I started to look into it today and a deep dive into the specifications is in order to ensure that the code behaves correctly in all cases so I haven't been able to cover everything yet.
|
I added the signature verification for SMB2 messages on client side.
Adding the attribute
m_sessionSetupResponseMessagetoSMB2Clientwas a bit lazy, but the easiest method to implement the check without changing to much of the library code. Maybe you have a better approach in mind @TalAloni ?Tests prove that the manipulation of the signature result in the desired behavior (either discarding the invalid message or disconnect from the server).